Skip to contentSkip to conversation

Fix Careless bio->_bio change in rq_for_each_bio().

PATCH In review Rusty Russell 2 participants 3 messages Jan 22, 2004 Block layer

lore
Share & tools
lore

Rusty Russell

author
#0 lore raw

PATCH 1/1 Fix Careless bio->_bio change in rq_for_each_bio().

Looks like an obvious typo. Works fine if "bio" is the name of the iterator.

include/linux/blkdev.h +1 -1
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.2-rc1/include/linux/blkdev.h tmp/include/linux/blkdev.h
@@ -485,7 +485,7 @@ static inline void blk_queue_bounce(requ
 
 #define rq_for_each_bio(_bio, rq)	\
 	if ((rq->bio))			\
-		for (_bio = (rq)->bio; _bio; _bio = bio->bi_next)
+		for (_bio = (rq)->bio; _bio; _bio = _bio->bi_next)
 
 struct sec_size {
 	unsigned block_size;

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

#1 lore raw
Quoted 2 lines · Rusty Russell

Looks like an obvious typo. Works fine if "bio" is the name of the iterator.

Rusty,

This was already posted a week or two ago, and has been in Linus' tree since yesterday (or the day before).

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 8 lines · Jens Axboe
Quoted 2 lines · Rusty Russell

Looks like an obvious typo. Works fine if "bio" is the name of the iterator.

Rusty,

This was already posted a week or two ago, and has been in Linus' tree since yesterday (or the day before).

Sorry misread that, there was an error in the fixup :)

Signature · 1 line
Jens Axboe