Skip to contentSkip to conversation

rivafb & small 16 bit mode problem

PATCH In review Rusty Russell 3 participants 3 messages Jan 22, 2004 – Jan 23, 2004 Framebuffer layer

lore
Share & tools
lore

Rusty Russell

author
#0 lore raw

PATCH 1/1 rivafb & small 16 bit mode problem

Ani,

I assume this should be in 2.6's drivers/video/riva/fbdev.c as
well?

Rusty.

Date: Thu, 8 Jan 2004 22:45:56 +0100
From: "[iso-8859-2] Pawe? Goleniowski" <[email protected]>
To: [email protected]
Cc: [email protected], [email protected]
Subject: [PATCH for 2.4.x] rivafb & small 16 bit mode problem

I have already send this once before Xmas but it probably got lost, so I'm sending it again:

There is a problem with 16 bit mode with rivafb. Colors are sometimes broken (specialy under Midnight Commander). This small patch fixes it. I've been using it for last months and it works without any problems.

Pawel 'Goldi' Goleniowski

--Boundary-00=_U+c//wvZdA6GwMA
Content-Type: TEXT/X-DIFF; CHARSET=iso-8859-2; NAME="patch-rivafb.diff"
Content-ID: <[email protected]> Content-Description:
Content-Disposition: ATTACHMENT; FILENAME="patch-rivafb.diff"

drivers/video/riva/accel.c +2 -2
@@ -300,8 +300,8 @@
 
 static inline void convert_bgcolor_16(u32 *col)
 {
-	*col = ((*col & 0x00007C00) << 9)
-             | ((*col & 0x000003E0) << 6)
+	*col = ((*col & 0x0000F800) << 8)
+             | ((*col & 0x000007E0) << 5)
              | ((*col & 0x0000001F) << 3)
              |          0xFF000000;
 }

--Boundary-00=_U+c//wvZdA6GwMA--

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

#1 lore raw

Dnia czw 22 stycznia 2004 05:51, Rusty Russell napisał/a:

Quoted 7 lines

Ani,

I assume this should be in 2.6's drivers/video/riva/fbdev.c as
well?

Rusty.

Well, I've just checked rivafb under 2.6.1 and I didn't notice this mistake - there are good colours in Midnight Commander. Probably this bug was repaired somewhere in 2.5.
But I have no idea which options should I send to kernel to get different resolution (video=riva:800x600-16@85 don't work) and I have very ugly Linux logo while booting ;)

Signature · 4 lines
	===>  Goldi  <===
Linux user since Jan 16 2000 (#176912)
Proletariusze wszystkich krajów świata
używajcie systemu Linux!
#2 lore raw
Quoted 3 lines · On Thu, 22 Jan 2004, [iso-8859-2] Pawe? Goleniowski wrote:

But I have no idea which options should I send to kernel to get different resolution (video=riva:800x600-16@85 don't work) and I have very ugly Linux logo while booting ;)

video=rivafb:800x600-16@85

          ^^

should work

IB

Signature · 4 lines
===========================================================================
Ingo Buescher <[email protected]>
"Maneuvering with an army is advantageous; with an undisciplined
multitude, most dangerous." -- Sun Tzu