Skip to contentSkip to conversation

Suspicious pointer usage in kobil_sct driver.

PATCH Applied [email protected] 2 participants 3 messages Jan 23, 2004 – Jan 27, 2004

Subsystems (2)
USB USB serial
lore
Share & tools
lore

[email protected]

author
#0 lore raw

Greg, is this what's intended here?

Dave

drivers/usb/serial/kobil_sct.c +1 -1
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/usb/serial/kobil_sct.c linux-2.5/drivers/usb/serial/kobil_sct.c
@@ -651,7 +651,7 @@ static int  kobil_ioctl(struct usb_seria
 		return 0;
 
 	case TCSETS:   // 0x5402
-		if (! &port->tty->termios) {
+		if (!(port->tty->termios)) {
 			dbg("%s - port %d Error: port->tty->termios is NULL", __FUNCTION__, port->number);
 			return -ENOTTY;
 		}
#1 lore raw
Quoted 1 line · On Fri, Jan 23, 2004 at 06:35:25AM +0000, [email protected] wrote:

Greg, is this what's intended here?

Yes, your patch is correct. I'll go apply it, thanks.

greg k-h

Quoted 12 lines

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/usb/serial/kobil_sct.c linux-2.5/drivers/usb/serial/kobil_sct.c

drivers/usb/serial/kobil_sct.c +1 -1
@@ -651,7 +651,7 @@ static int  kobil_ioctl(struct usb_seria
 		return 0;
 
 	case TCSETS:   // 0x5402
-		if (! &port->tty->termios) {
+		if (!(port->tty->termios)) {
 			dbg("%s - port %d Error: port->tty->termios is NULL", __FUNCTION__, port->number);
 			return -ENOTTY;
 		}