md/raid6 breaks separate source/object tree
Subsystems (2)
md/raid6 is using an in-tree perl script to generate a C file. This breaks kbuild separate src/obj tree.
CC [M] drivers/md/raid6main.o CC [M] drivers/md/raid6algos.o CC [M] drivers/md/raid6recov.o HOSTCC drivers/md/mktables
drivers/md/mktables > drivers/md/raid6tables.c || ( rm -f drivers/md/raid6tables.c && exit 1 )
CC [M] drivers/md/raid6tables.o
perl drivers/md/unroll.pl 1 < /usr/src/linux-2.6.2-rc1.1.A/drivers/md/raid6int.uc > drivers/md/raid6int1.c || ( rm -f drivers/md/raid6int1.c && exit 1 ) Can't open perl script "drivers/md/unroll.pl": No such file or directory
Somehow the src in $(PERL) $(src)/drivers/md/unroll.pl is not getting substituted.
Still trying to figure it out...
Quoted 16 lines · Richard Chan
md/raid6 is using an in-tree perl script to generate a C file. This breaks kbuild separate src/obj tree.
CC [M] drivers/md/raid6main.o CC [M] drivers/md/raid6algos.o CC [M] drivers/md/raid6recov.o HOSTCC drivers/md/mktables
drivers/md/mktables>drivers/md/raid6tables.c|| ( rm -fdrivers/md/raid6tables.c&& exit 1 )
CC [M]drivers/md/raid6tables.o
perldrivers/md/unroll.pl1 </usr/src/linux-2.6.2-rc1.1.A/drivers/md/raid6int.uc>drivers/md/raid6int1.c|| ( rm -fdrivers/md/raid6int1.c&& exit 1 ) Can't open perl script "drivers/md/unroll.pl": No such file or directory
Quoted 2 lines
Somehow the src in $(PERL) $(src)/drivers/md/unroll.pl is not getting substituted.
Does this patch (from Sam) fix it?
drivers/md/Makefile renamed from drivers/md/Makefile~raid-makefile-cleanup +40 -23
@@ -24,26 +24,43 @@ obj-$(CONFIG_MD_MULTIPATH) += multipath. obj-$(CONFIG_BLK_DEV_MD) += md.o obj-$(CONFIG_BLK_DEV_DM) += dm-mod.o -# Files generated that shall be removed upon make clean -clean-files := raid6int*.c raid6tables.c mktables - -$(obj)/raid6int1.c: $(src)/raid6int.uc $(src)/unroll.pl - $(PERL) $(src)/unroll.pl 1 < $< > $@ || ( rm -f $@ && exit 1 ) - -$(obj)/raid6int2.c: $(src)/raid6int.uc $(src)/unroll.pl - $(PERL) $(src)/unroll.pl 2 < $< > $@ || ( rm -f $@ && exit 1 ) - -$(obj)/raid6int4.c: $(src)/raid6int.uc $(src)/unroll.pl - $(PERL) $(src)/unroll.pl 4 < $< > $@ || ( rm -f $@ && exit 1 ) - -$(obj)/raid6int8.c: $(src)/raid6int.uc $(src)/unroll.pl - $(PERL) $(src)/unroll.pl 8 < $< > $@ || ( rm -f $@ && exit 1 ) - -$(obj)/raid6int16.c: $(src)/raid6int.uc $(src)/unroll.pl - $(PERL) $(src)/unroll.pl 16 < $< > $@ || ( rm -f $@ && exit 1 ) - -$(obj)/raid6int32.c: $(src)/raid6int.uc $(src)/unroll.pl - $(PERL) $(src)/unroll.pl 32 < $< > $@ || ( rm -f $@ && exit 1 ) - -$(obj)/raid6tables.c: $(obj)/mktables - $(obj)/mktables > $@ || ( rm -f $@ && exit 1 ) +quiet_cmd_unroll = UNROLL $@ + cmd_unroll = $(PERL) $(srctree)/$(src)/unroll.pl $(UNROLL) \ + < $< > $@ || ( rm -f $@ && exit 1 ) + +targets += raid6int1.c +$(obj)/raid6int1.c: UNROLL := 1 +$(obj)/raid6int1.c: $(src)/raid6int.uc $(src)/unroll.pl FORCE + $(call if_changed,unroll) + +targets += raid6int2.c +$(obj)/raid6int2.c: UNROLL := 2 +$(obj)/raid6int2.c: $(src)/raid6int.uc $(src)/unroll.pl FORCE + $(call if_changed,unroll) + +targets += raid6int4.c +$(obj)/raid6int4.c: UNROLL := 4 +$(obj)/raid6int4.c: $(src)/raid6int.uc $(src)/unroll.pl FORCE + $(call if_changed,unroll) + +targets += raid6int8.c +$(obj)/raid6int8.c: UNROLL := 8 +$(obj)/raid6int8.c: $(src)/raid6int.uc $(src)/unroll.pl FORCE + $(call if_changed,unroll) + +targets += raid6int16.c +$(obj)/raid6int16.c: UNROLL := 16 +$(obj)/raid6int16.c: $(src)/raid6int.uc $(src)/unroll.pl FORCE + $(call if_changed,unroll) + +targets += raid6int32.c +$(obj)/raid6int32.c: UNROLL := 32 +$(obj)/raid6int32.c: $(src)/raid6int.uc $(src)/unroll.pl FORCE + $(call if_changed,unroll) + +quiet_cmd_mktable = TABLE $@ + cmd_mktable = $(obj)/mktables > $@ || ( rm -f $@ && exit 1 ) + +targets += raid6tables.c +$(obj)/raid6tables.c: $(obj)/mktables FORCE + $(call if_changed,mktable)
_