Skip to contentSkip to conversation

fix logic bugs in ps2esdi.c

PATCH In review Timmy Yee 1 participant 2 messages Jan 26, 2004 – Jan 27, 2004

Subsystems (2)
Block layer Kernel janitors
lore
Share & tools
lore

Timmy Yee

author
#0 lore raw

PATCH 1/1 fix logic bugs in ps2esdi.c

Hi,

This patch adds missing ampersands.

drivers/block/ps2esdi.c +2 -2
@@ -743,7 +743,7 @@
 	drive_num = int_ret_code >> 5;
 	switch (int_ret_code & 0xf) {
 	case INT_CMD_COMPLETE:
-		for (i = ESDI_TIMEOUT; i & !(inb(ESDI_STATUS) & STATUS_STAT_AVAIL); i--);
+		for (i = ESDI_TIMEOUT; i && !(inb(ESDI_STATUS) & STATUS_STAT_AVAIL); i--);
 		if (!(inb(ESDI_STATUS) & STATUS_STAT_AVAIL)) {
 			printk("%s: timeout reading status word\n", DEVICE_NAME);
 			outb((int_ret_code & 0xe0) | ATT_EOI, ESDI_ATTN);

@@ -879,7 +879,7 @@
 		break;
 
 	case INT_CMD_COMPLETE:
-		for (i = ESDI_TIMEOUT; i & !(inb(ESDI_STATUS) & STATUS_STAT_AVAIL); i--);
+		for (i = ESDI_TIMEOUT; i && !(inb(ESDI_STATUS) & STATUS_STAT_AVAIL); i--);
 		if (!(inb(ESDI_STATUS) & STATUS_STAT_AVAIL)) {
 			printk("%s: timeout reading status word\n", DEVICE_NAME);
 			outb((int_ret_code & 0xe0) | ATT_EOI, ESDI_ATTN);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#1 lore raw

Hi Walter,

Quoted 8 lines · Walter Harms

hi Timmy,
nice work,
perhaps you can do a bit clean up ? even the autor seem to have lost track in its code.

walter

Actually, I was planning to clean up the ps2esdi driver's module code and port it to the new MCA API when I find some time to do so.

Later,
Timmy
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors