Skip to contentSkip to conversation

Bring w83l785ts in compliance with sysfs naming

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bring w83l785ts in compliance with sysfs naming

Hi Greg,

Here is a patch that brings the w83l785ts driver in compliance with sysfs naming conventions. This is pretty much the same problem and solution that occured very recently with the lm75 and lm78 drivers.

The patch was tested to work fine by James Bolt.

If it's too late for Linux 2.6.2, this is no big deal. I'd add a workaround in libsensors before releasing lm_sensors 2.8.4, and remove it right after.

Thanks.

drivers/i2c/chips/w83l785ts.c renamed from drivers/i2c/chips/w83l785ts.c.orig +4 -4
@@ -137,8 +137,8 @@
 	return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp_over));
 }
 
-static DEVICE_ATTR(temp_input, S_IRUGO, show_temp, NULL)
-static DEVICE_ATTR(temp_max, S_IRUGO, show_temp_over, NULL)
+static DEVICE_ATTR(temp_input1, S_IRUGO, show_temp, NULL)
+static DEVICE_ATTR(temp_max1, S_IRUGO, show_temp_over, NULL)
 
 /*
  * Real code
@@ -249,8 +249,8 @@
 	 */
 
 	/* Register sysfs hooks */
-	device_create_file(&new_client->dev, &dev_attr_temp_input);
-	device_create_file(&new_client->dev, &dev_attr_temp_max);
+	device_create_file(&new_client->dev, &dev_attr_temp_input1);
+	device_create_file(&new_client->dev, &dev_attr_temp_max1);
 
 	return 0;
 
Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
Applied
#1 lore raw

PATCH 1/1 Bring w83l785ts in compliance with sysfs naming

Quoted 11 lines · Jean Delvare

Hi Greg,

Here is a patch that brings the w83l785ts driver in compliance with sysfs naming conventions. This is pretty much the same problem and solution that occured very recently with the lm75 and lm78 drivers.

The patch was tested to work fine by James Bolt.

If it's too late for Linux 2.6.2, this is no big deal. I'd add a workaround in libsensors before releasing lm_sensors 2.8.4, and remove it right after.

Applied, thanks.

It's too late for 2.6.2, sorry.

greg k-h