Skip to contentSkip to conversation

Add EXPORT_SYMBOL for physical_node_map

PATCH In review Martin Hicks 4 participants 8 messages Feb 3, 2004 – Feb 11, 2004

lore
Share & tools
lore

Martin Hicks

author
#0 lore raw

PATCH 1/1 Add EXPORT_SYMBOL for physical_node_map

Hi David,

Can you please include this EXPORT_SYMBOL in the next release. A few macros that use physical_node_map are used in modules.

Thanks
mh

Signature · 2 lines
Martin Hicks                Wild Open Source Inc.
[email protected]     613-266-2296

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas:
# ChangeSet 1.1542 -> 1.1543
# arch/ia64/sn/kernel/setup.c 1.28 -> 1.29
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/02/03 [email protected] 1.1543
# EXPORT_SYMBOL for physical_node_map. This is required

# for some SN2 modules.
# --------------------------------------------
#
diff -Nru a/arch/ia64/sn/kernel/setup.c b/arch/ia64/sn/kernel/setup.c
--- a/arch/ia64/sn/kernel/setup.c	Tue Feb  3 12:52:53 2004
+++ b/arch/ia64/sn/kernel/setup.c	Tue Feb  3 12:52:53 2004
@@ -70,6 +70,8 @@

short physical_node_map[MAX_PHYSNODE_ID];

+EXPORT_SYMBOL(physical_node_map);
+
int numionodes;

/*

#1 lore raw
Quoted 2 lines · Martin Hicks

Can you please include this EXPORT_SYMBOL in the next release. A few macros that use physical_node_map are used in modules.

which module? There isn't one in the current tree and it would have to be horribly SN2-specific as it's a SN2 only variable.

And no, my $RANDOM binary module doesn't count.

#2 lore raw
In reply to Martin Hicks

You should probably include module.h too...

Quoted 39 lines · Martin Hicks

Hi David,

Can you please include this EXPORT_SYMBOL in the next release. A few macros that use physical_node_map are used in modules.

Thanks
mh

Signature · 18 lines
Martin Hicks                Wild Open Source Inc.
[email protected]     613-266-2296

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1542  -> 1.1543 
#	arch/ia64/sn/kernel/setup.c	1.28    -> 1.29   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/02/03	[email protected]	1.1543
# EXPORT_SYMBOL for physical_node_map.  This is required
# for some SN2 modules.
# --------------------------------------------
#
diff -Nru a/arch/ia64/sn/kernel/setup.c b/arch/ia64/sn/kernel/setup.c
arch/ia64/sn/kernel/setup.c +2 -0
@@ -70,6 +70,8 @@
 
 short physical_node_map[MAX_PHYSNODE_ID];
 
+EXPORT_SYMBOL(physical_node_map);
+
 int     numionodes;
 
 /*
author
#3 lore raw
In reply to Martin Hicks
Quoted 8 lines · Christoph Hellwig
Quoted 2 lines · Martin Hicks

Can you please include this EXPORT_SYMBOL in the next release. A few macros that use physical_node_map are used in modules.

which module? There isn't one in the current tree and it would have to be horribly SN2-specific as it's a SN2 only variable.

And no, my $RANDOM binary module doesn't count.

Yes, that's what it is. Some-random-binary-module.

It does pollute GENERIC a bit, but I didn't think that would matter too much.

Signature · 2 lines
Martin Hicks                Wild Open Source Inc.
[email protected]     613-266-2296
#4 lore raw
In reply to Martin Hicks
Quoted 9 lines · Martin Hicks
Quoted 4 lines

which module? There isn't one in the current tree and it would have to be horribly SN2-specific as it's a SN2 only variable.

And no, my $RANDOM binary module doesn't count.

Yes, that's what it is. Some-random-binary-module.

It does pollute GENERIC a bit, but I didn't think that would matter too much.

Well, then you're on your own. Export it in the SGI tree if your lawyers feel comfortable with it.

#5 lore raw
In reply to Martin Hicks
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Martin Hicks

Martin> Can you please include this EXPORT_SYMBOL in the next release. A few Martin> macros that use physical_node_map are used in modules.

I share Christoph's concern but since this code is SGI's and Jesse is apparently OK with it, I'd have applied it---if only the patch actually applied. I think there is some whitespace breakage in your patch.

	--david
#6 lore raw
In reply to Martin Hicks
Quoted 9 lines · David Mosberger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Martin Hicks

Martin> Can you please include this EXPORT_SYMBOL in the next release. A few Martin> macros that use physical_node_map are used in modules.

I share Christoph's concern but since this code is SGI's and Jesse is apparently OK with it, I'd have applied it---if only the patch actually applied. I think there is some whitespace breakage in your patch.

Yep, I'm ok with it. The modules that depend on it should be released under the GPL soon. Robin is working on getting them into shape for inclusion into the mainline tree.

Thanks,
Jesse

author
#7 lore raw
In reply to Martin Hicks
Quoted 9 lines · David Mosberger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Martin Hicks

Martin> Can you please include this EXPORT_SYMBOL in the next release. A few Martin> macros that use physical_node_map are used in modules.

I share Christoph's concern but since this code is SGI's and Jesse is apparently OK with it, I'd have applied it---if only the patch actually applied. I think there is some whitespace breakage in your patch.

Here's another attempt then. Against Linus' latest bk tree.

mh

Signature · 1 line
Martin Hicks || [email protected] || PGP/GnuPG: 0x4C7F2BEE

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas:
# ChangeSet 1.1610 -> 1.1611
# arch/ia64/sn/kernel/setup.c 1.31 -> 1.32
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/02/11 [email protected] 1.1611
# Export physical_node_map
# --------------------------------------------
#

arch/ia64/sn/kernel/setup.c +2 -0
diff -Nru a/arch/ia64/sn/kernel/setup.c b/arch/ia64/sn/kernel/setup.c
@@ -71,6 +71,8 @@
 
 short physical_node_map[MAX_PHYSNODE_ID];
 
+EXPORT_SYMBOL(physical_node_map);
+
 int	numionodes;
 /*
  * This is the address of the RRegs in the HSpace of the global