Skip to contentSkip to conversation

IA32 (2.6.2 - 2004-02-05.22.30) - 3 New warnings (gcc 3.2.2)

DISCUSSION Jon Foster 2 participants 2 messages Feb 8, 2004

lore
Share & tools
lore

Jon Foster

author
#0 lore raw
Quoted 9 lines · Linus
Quoted 3 lines · On Fri, 6 Feb 2004 viro wrote:

IOW, gcc doesn't realize that we never return from BUG(). AFAICS, it should. Some changes of __volatile__ semantics?

Thsrs is no way to tell gcc that an inline asm doesn't return. The only way to do it would be to add something like a "for (;;);" (that gcc will actually generate real code for) inside the BUG() macro, but I'd hate to do that.

Why would you hate to do that? Because of the extra code this generates? Or because it's a hack (we should just be able to tell GCC that the inline assembly never returns)?

Although the loop does generate real code, GCC is currently generating real code to handle what happens after BUG() returns. The two pretty much cancel each other out - they're both basically a jump (possibly with a nop for alignment). This is extremely non-obvious (at least to me), since the code to handle BUG() returning is implicit, whereas the for(;;); is explicit.

I've just done some benchmarks (using a vendor 2.4 kernel) and the for(;;); change actually reduced the kernel size. The change was a negligible amount, almost lost in the noise, but at least the size didn't go up. See my recent l-k post "Re: [Compile Regression in 2.4.25-pre8][PATCH 37/42]".

I agree with Viro that the best solution would be if there was some way to tell GCC that the inline assembly doesn't return - probably by attaching __attribute__((noreturn)) to it.

Kind regards,

Jon

Quoted 5 lines

Better to just initialize the variable to a default value and avoid the warning for now.

Linus

#1 lore raw
Quoted 3 lines · Jon Foster

I agree with Viro that the best solution would be if there was some way to tell GCC that the inline assembly doesn't return - probably by attaching __attribute__((noreturn)) to it.

That __attribute__ would have to go with __asm__ - it should tell gcc that insn has no successors. And that would be a PITA to deal with
- gcc parser is not a thing of beauty as it is, so changing it would not be fun.

Easier to express that as an asm constraint - then it will have no impact on the high-level parser and constraint parser is simple enough...