Skip to contentSkip to conversation

IDE 80-core cable detect - chipset-specific code to over-ride eighty_ninty_three()

RFC Athol Mullen 3 participants 4 messages Feb 8, 2004 – Feb 10, 2004 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 1 line · Willy Tarreau

On Sat, Feb 07, 2004 at 05:00:18PM +1100, Athol Mullen wrote:

(Don't CC. I read lkml via linux.kernel newsgroup.)

Quoted 7 lines
Quoted 3 lines

After looking through the Intel specs for the ICH5, I discovered that they specify that the BIOS is supposed to initialise bit flags for the presence of 80-core ribbon for each drive.

that could explain why I recently discovered that a 2.4.25-rc1 on a supermicro MB with ICH5 was limiting hda and hdb to 30 MB/s at UDMA33 while an old 2.4.20 + many patches including IDE gave me about 64 MB/s at UDMA100.

Before I modified eighty_ninty_three(), it returning 0 caused the _indicated_ mode to drop to UDMA33. Check in /proc/ide/piix to see what mode the driver tells you. IIRC (could be wrong), dmesg and hdparm both believe it to be in UDMA33 while the init code and /proc/ide/piix both showed it as UDMA5.

I'm starting to wonder if my ICH5 _is_ actually running UDMA5... It's doing 21MB/s, which I've been blaming on the old 30G Quantum, whereas the ICH4 with a 120G drive is doing 56MB/s... I think I checked the bit flags in /proc/ide/ide0/config and it showed up as UDMA5.

Quoted 8 lines
Quoted 6 lines

I'm not certain exactly how this would be implemented, but I'd like to see eighty_ninty_three() check for chipset-specific detection code, and use the existing word93 validation otherwise.

I have written and tested code for the intel ICH chipsets, but can't post a patch until I know where to stick it. :-)

well, why not in piix:piix_ratemask() around line 315 ?

I could put it there, but I was actually intending to use it to also return a value properly for eighty_ninty_three(), and figured that it would need to be a separate routine - I expect that the module structure needs to change, and that's where I'm not sure - it could affect _all_ ide drivers. There might be others that have their own specific detection code, and what I'm looking to do is establish the framework for that.

Yes, there was a fairly stupid stuff-up on my part in my previous message - my business .sig wasn't supposed to get tacked on after my usenet .sig... It _was_ a spam-free email address. :-(

Signature · 4 lines
Athol
<http://cust.idl.com.au/athol>
Linux Registered User # 254000
I'm a Libran Engineer. I don't argue, I discuss.
#3 lore raw
Quoted 4 lines · Athol Mullen

Before I modified eighty_ninty_three(), it returning 0 caused the _indicated_ mode to drop to UDMA33. Check in /proc/ide/piix to see what mode the driver tells you. IIRC (could be wrong), dmesg and hdparm both believe it to be in UDMA33 while the init code and /proc/ide/piix both showed it as UDMA5.

I captured dmesg and /proc/ide/piix, but forgot to post them. They're at work now. But I did the change, by commenting out the call to eighty_ninety_three() in piix.c, and my disks came back to 54 MB/s each, and 64 MB/s cumulated. dmesg showed UDMA33 before and now displays UDMA100 again. But I obviously cannot let it like that because if I install this kernel in a 40-pin machine, I will get some surprizes !

Quoted 4 lines

I'm starting to wonder if my ICH5 _is_ actually running UDMA5... It's doing 21MB/s, which I've been blaming on the old 30G Quantum, whereas the ICH4 with a 120G drive is doing 56MB/s... I think I checked the bit flags in /proc/ide/ide0/config and it showed up as UDMA5.

I'm certain that this one changed before and after the patch, but I cannot tell you what the differences were.

Quoted 10 lines
Quoted 3 lines
Quoted 2 lines

I'm not certain exactly how this would be implemented, but I'd like to see eighty_ninty_three() check for chipset-specific detection code, and use the

well, why not in piix:piix_ratemask() around line 315 ?

I could put it there, but I was actually intending to use it to also return a value properly for eighty_ninty_three(), and figured that it would need to be a separate routine - I expect that the module structure needs to change, and that's where I'm not sure - it could affect _all_ ide drivers. There might be others that have their own specific detection code, and what I'm looking to do is establish the framework for that.

I understand. But could you please post your ICH5 detection code so that I can try it on this machine. I still can play with it for a few days before it gets racked. And I can try with both 40 and 80-pin cables.

Quoted 2 lines

business .sig wasn't supposed to get tacked on after my usenet .sig... It _was_ a spam-free email address. :-(

Now the only thing you can do is to count how many days elapse before you get your first spam...

Regards,
Willy

#4 lore raw
Quoted 6 lines · Willy Tarreau
Quoted 5 lines · Athol Mullen

Before I modified eighty_ninty_three(), it returning 0 caused the _indicated_ mode to drop to UDMA33. Check in /proc/ide/piix to see what mode the driver tells you. IIRC (could be wrong), dmesg and hdparm both believe it to be in UDMA33 while the init code and /proc/ide/piix both showed it as UDMA5.

So host recognizes 80-wires cable correctly, but drive doesn't. eighty_ninty_three() is for checking _drive_ side.

Quoted 6 lines

I captured dmesg and /proc/ide/piix, but forgot to post them. They're at work now. But I did the change, by commenting out the call to eighty_ninety_three() in piix.c, and my disks came back to 54 MB/s each, and 64 MB/s cumulated. dmesg showed UDMA33 before and now displays UDMA100 again. But I obviously cannot let it like that because if I install this kernel in a 40-pin machine, I will get some surprizes !

This is eighty_ninty_three() in 2.6.x (except #if 0 (...) #endif code):

u8 eighty_ninty_three (ide_drive_t *drive)

{
	return ((u8) ((HWIF(drive)->udma_four) &&
#ifndef CONFIG_IDEDMA_IVB
			(drive->id->hw_config & 0x4000) &&
#endif /* CONFIG_IDEDMA_IVB */
			(drive->id->hw_config & 0x6000)) ? 1 : 0);

#endif
}

Maybe you have accidentally enabled CONFIG_IDEDMA_IVB?
If not please send me copy of /proc/ide/hdX/identify for your drives.

--bart

#5 lore raw
Quoted 10 lines · Bartlomiej Zolnierkiewicz
Quoted 6 lines · Willy Tarreau
Quoted 5 lines · Athol Mullen

Before I modified eighty_ninty_three(), it returning 0 caused the _indicated_ mode to drop to UDMA33. Check in /proc/ide/piix to see what mode the driver tells you. IIRC (could be wrong), dmesg and hdparm both believe it to be in UDMA33 while the init code and /proc/ide/piix both showed it as UDMA5.

So host recognizes 80-wires cable correctly, but drive doesn't. eighty_ninty_three() is for checking _drive_ side.

It is for both host and drive sides.
I should have read my mail before hitting SEND button. ;-)