udev add wild card compare for ID

PATCH In review Patrick Mansfield 2 participants 2 messages Feb 12, 2004

lore

Share & tools

lore

Patrick Mansfield

author

2004-02-12 00:33 UTC #0 lore raw

PATCH 1/1 udev add wild card compare for ID

Patch on top of previous patch.

Allow wild card comparison of the ID.

Using strcmp_pattern here also means we on longer match partial values, for example, a scsi rule like this won't match anymore:

	BUS="scsi", ID=":0", NAME="sdfoo-short-bus_id-1"

But this now works:

	BUS="scsi", ID="*:0", NAME="sdfoo-bus_id-wild-card-1"

=== namedev.c 1.101 vs edited ==--- 1.101/namedev.c Wed Feb 11 16:20:32 2004
+++ edited/namedev.c Wed Feb 11 16:24:00 2004
@@ -477,8 +477,9 @@

strfieldcpy(path, sysfs_device->path);
temp = strrchr(path, '/');
+ temp++;
dbg("search '%s' in '%s', path='%s'", dev->id, temp, path);
- if (strstr(temp, dev->id) = NULL)
+ if (strcmp_pattern(dev->id, temp) != 0)
return -ENODEV;
else
return 0;

-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id56&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Greg KH

2004-02-12 01:26 UTC #1 lore raw

Quoted 4 lines · Patrick Mansfield

Patch on top of previous patch.
Allow wild card comparison of the ID.

Quoted 8 lines

Using strcmp_pattern here also means we on longer match partial values, for example, a scsi rule like this won't match anymore:
	BUS="scsi", ID=":0", NAME="sdfoo-short-bus_id-1"
But this now works:
	BUS="scsi", ID="*:0", NAME="sdfoo-bus_id-wild-card-1"

Nice, I've applied this.

Care to write up a rule for udev-test.pl so we don't accidentially break this feature some time in the future?

thanks,

greg k-h