: Sparc no longer Fucked Up
PATCH 1/1 : Sparc no longer Fucked Up
From: Keith M Wesolowski <[email protected]>
As of 2.6.3, restore_flags will no longer modify cwp on sparc. Therefore you can apply this patch to the locking guide.
[ Indeed. I'll also remove the atomic comments from Hacking
Guide as part of my revision there when I get back to it. --RR ]
Documentation/DocBook/kernel-locking.tmpl +0 -21
@@ -1444,27 +1444,6 @@ </para> </sect1> - <sect1 id="sparc"> - <title>The Fucked Up Sparc</title> - - <para> - Alan Cox says <quote>the irq disable/enable is in the register - window on a sparc</quote>. Andi Kleen says <quote>when you do - restore_flags in a different function you mess up all the - register windows</quote>. - </para> - - <para> - So never pass the flags word set by - <function>spin_lock_irqsave()</function> and brethren to another - function (unless it's declared <type>inline</type>). Usually no-one - does this, but now you've been warned. Dave Miller can never do - anything in a straightforward manner (I can say that, because I have - pictures of him and a certain PowerPC maintainer in a compromising - position). - </para> - </sect1> - </chapter> <chapter id="Efficiency">
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.