Skip to contentSkip to conversation

ppc64: fix debugger() warnings

PATCH Arjan van de Ven 2 participants 2 messages Feb 19, 2004 – Feb 20, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review

Quoted 3 lines · Linux Kernel Mailing List
(quoted diff) +3 -0
+static inline int debugger(struct *pt_regs regs) { return 0; }
+static inline int debugger_bpt(struct *pt_regs regs) { return 0; }
+static inline int debugger_sstep(struct *pt_regs regs) { return 0; }

I guess these work a LOT better if you type them as "struct pt_regs *regs) instead of 'struct *pt_regs regs'

#2 lore raw
Quoted 7 lines

Review

Quoted 4 lines
(quoted diff) +3 -0
+static inline int debugger(struct *pt_regs regs) { return 0; }
+static inline int debugger_bpt(struct *pt_regs regs) { return 0; }
+static inline int debugger_sstep(struct *pt_regs regs) { return 0; }

I guess these work a LOT better if you type them as "struct pt_regs *regs) instead of 'struct *pt_regs regs'

Wow thats some impressively shit coding on my part :) Thanks for catching it.

Anton