Skip to contentSkip to conversation

Another oops in i2c-core with debug

PATCH Applied Jean Delvare 2 participants 2 messages Feb 22, 2004 – Feb 24, 2004 I2C

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 Another oops in i2c-core with debug

Hi Greg,

Some times ago, you fixed an oops in i2c-core when debugging is enabled:
http://marc.theaimsgroup.com/?l=linux-kernel&m=107585749612115&w=2

Looks like you missed that second one:

drivers/i2c/i2c-core.c +1 -1
@@ -618,7 +618,7 @@
 	int ret = 0;
 	struct i2c_adapter *adap = client->adapter;
 
-	dev_dbg(&client->dev, "i2c ioctl, cmd: 0x%x, arg: %#lx\n", cmd, arg);
+	dev_dbg(&client->adapter->dev, "i2c ioctl, cmd: 0x%x, arg: %#lx\n", cmd, arg);
 	switch (cmd) {
 		case I2C_RETRIES:
 			adap->retries = arg;

Reported by Emil Svensson on IRC. Sensors-detect would trigger the oops (through i2c-dev), I could reproduce it easily. Works OK after applying the patch above.

Please apply,
Thanks.

Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/