Skip to contentSkip to conversation

SAL version is not zero-padded

PATCH In review Matthew Wilcox 2 participants 4 messages Feb 23, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SAL version is not zero-padded

SAL is version 3.1, not 3.01.

arch/ia64/kernel/sal.c +1 -1
diff -urpNX build-tools/dontdiff linus-2.6/arch/ia64/kernel/sal.c pciexp-2.6/arch/ia64/kernel/sal.c
@@ -106,7 +106,7 @@ ia64_sal_init (struct ia64_sal_systab *s
 	/*
 	 * revisions are coded in BCD, so %x does the job for us
 	 */
-	printk(KERN_INFO "SAL v%x.%02x: oem=%.32s, product=%.32s\n",
+	printk(KERN_INFO "SAL v%x.%x: oem=%.32s, product=%.32s\n",
 	       systab->sal_rev_major, systab->sal_rev_minor,
 	       systab->oem_id, systab->product_id);
 
Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Matthew Wilcox

Matthew> SAL is version 3.1, not 3.01.

- printk(KERN_INFO "SAL v%x.%02x: oem=%.32s, product=%.32s\n",
+ printk(KERN_INFO "SAL v%x.%x: oem=%.32s, product=%.32s\n",

Eh, it was printing a _byte_. If you remove the byte-printing, I suspect you'd also want to switch to a decimal format.

	--david
#2 lore raw
In reply to Matthew Wilcox
Quoted 9 lines · David Mosberger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Matthew Wilcox

Matthew> SAL is version 3.1, not 3.01.

arch/ia64/kernel/sal.c +1 -1
-	printk(KERN_INFO "SAL v%x.%02x: oem=%.32s, product=%.32s\n",
+	printk(KERN_INFO "SAL v%x.%x: oem=%.32s, product=%.32s\n",

Eh, it was printing a _byte_. If you remove the byte-printing, I suspect you'd also want to switch to a decimal format.

No, it's still BCD encoded. So it'll go from 0x09 to 0x10 when we move from 3.9 to 3.10. It just shouldn't be 0-padded.

Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
#3 lore raw
In reply to Matthew Wilcox
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line · Matthew Wilcox

- printk(KERN_INFO "SAL v%x.%02x: oem=%.32s, product=%.32s\n", +
printk(KERN_INFO "SAL v%x.%x: oem=%.32s, product=%.32s\n",

Eh, it was printing a _byte_. If you remove the byte-printing, I suspect you'd also want to switch to a decimal format.

Matthew> No, it's still BCD encoded. So it'll go from 0x09 to 0x10 Matthew> when we move from 3.9 to 3.10. It just shouldn't be Matthew> 0-padded.

Ah, that's OK then.

Thanks,

	--david