Skip to contentSkip to conversation

drivers/char/rio ioctl return fixes.

Kernel-janitors Tony Breeds 1 participant 1 message Feb 24, 2004

Subsystems (2)
Kernel janitors Char and misc drivers
lore
Share & tools
lore

Tony Breeds

author
#0 lore raw

Hello all,
This is a patch that I've been floating past lkml since 2.5.10
(or there abouts). It fixes 3 places where the ioctl returns positives instead of negatives. I've gotten feedback from the maintainer (Rogier Wolfe (sp?) and he has no objections.

Feedback more than welcome.
-----

drivers/char/rio/rioctrl.c +3 -3
diff -X dontdiff -urN 2.6.3.clean/drivers/char/rio/rioctrl.c 2.6.3.rio/drivers/char/rio/rioctrl.c
@@ -522,7 +522,7 @@
 					else {
 		 				rio_dprintk (RIO_DEBUG_CTRL, "p->RIOBindTab full! - Rta %x not added\n",
 		  					(int) arg);
-		 				return 1;
+		 				return -ENOMEM;
 					}
 					return 0;
 				}

@@ -1593,12 +1593,12 @@
 			case RIO_NO_MESG:
 				if ( su )
 					 p->RIONoMessage = 1;
-				return su ? 0 : EPERM;
+				return su ? 0 : -EPERM;
 
 			case RIO_MESG:
 				if ( su )
 					p->RIONoMessage = 0;
-				return su ? 0 : EPERM;
+				return su ? 0 : -EPERM;
 
 			case RIO_WHAT_MESG:
 				if ( copyout( (caddr_t)&p->RIONoMessage, (int)arg,

-----

Yours Tony

linux.conf.au http://lca2005.linux.org.au/
Apr 18-23 2005 The Australian Linux Technical Conference!

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors