Skip to contentSkip to conversation

2.6.3 - fix for undefined mdelay in 3c505

PATCH Applied Jakub Bogusz 3 participants 5 messages Feb 25, 2004 – Feb 26, 2004 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.6.3 - fix for undefined mdelay in 3c505

This patch fixes undefined mdelay() in 3c505 driver - at least on alpha (maybe on other archs <linux/delay.h> is included by some other headers, but on alpha it isn't) there was warning:

*** Warning: "mdelay" [drivers/net/3c505.ko] undefined!

Signature · 2 lines
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Team        http://www.pld-linux.org/

fixes "*** Warning: "mdelay" [drivers/net/3c505.ko] undefined!"

drivers/net/3c505.c renamed from drivers/net/3c505.c.orig +1 -0
@@ -106,6 +106,7 @@
 #include <linux/ioport.h>
 #include <linux/spinlock.h>
 #include <linux/ethtool.h>
+#include <linux/delay.h>
 
 #include <asm/uaccess.h>
 #include <asm/bitops.h>
#1 lore raw
Quoted 5 lines · Jakub Bogusz

This patch fixes undefined mdelay() in 3c505 driver - at least on alpha (maybe on other archs <linux/delay.h> is included by some other headers, but on alpha it isn't) there was warning:

*** Warning: "mdelay" [drivers/net/3c505.ko] undefined!

You aren't seriously using a 3c505 on an Alpha, are you?!

Regards: David Weinehall

Signature · 3 lines
 /) David Weinehall <[email protected]> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/
#2 lore raw
Quoted 8 lines · David Weinehall
Quoted 5 lines · Jakub Bogusz

This patch fixes undefined mdelay() in 3c505 driver - at least on alpha (maybe on other archs <linux/delay.h> is included by some other headers, but on alpha it isn't) there was warning:

*** Warning: "mdelay" [drivers/net/3c505.ko] undefined!

You aren't seriously using a 3c505 on an Alpha, are you?!

No, I'm not. Just trying to compile kernel with "most-module/most-yes" config ;)
Kconfig allows to enable this, so it should build cleanly, right?

Signature · 2 lines
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Team        http://www.pld-linux.org/
#3 lore raw
Quoted 6 lines · Jakub Bogusz
Quoted 5 lines · David Weinehall
Quoted 4 lines · Jakub Bogusz

This patch fixes undefined mdelay() in 3c505 driver - at least on alpha (maybe on other archs <linux/delay.h> is included by some other headers, but on alpha it isn't) there was warning:

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

*** Warning: "mdelay" [drivers/net/3c505.ko] undefined!

You aren't seriously using a 3c505 on an Alpha, are you?!

No, I'm not. Just trying to compile kernel with "most-module/most-yes" config ;)

Good, got a little worried there...

Quoted 1 line

Kconfig allows to enable this, so it should build cleanly, right?

Oh, indeed, and killing warnings is rarely a bad thing (it can sometimes be harmful though, if it hides more serious problems. That's not the case here, however).

Regards: David Weinehall

Signature · 3 lines
 /) David Weinehall <[email protected]> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/