Skip to contentSkip to conversation

S390 block devs on !s390.

PATCH Dave Jones 2 participants 5 messages Feb 27, 2004 s390

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

This is probably useless on x86 for eg..
(Everything else in this file is dependant on some other s390 feature,
so only this one shows up). Too bad the drivers/s390/block stuff gets
source'd at all on !s390.

Dave

drivers/s390/block/Kconfig renamed from drivers/s390/block/Kconfig~ +1 -0
@@ -13,6 +13,7 @@
 
 config DCSSBLK
 	tristate "DCSSBLK support"
+	depends on ARCH_S390
 	help
 	  Support for dcss block device
 
#1 lore raw
Quoted 4 lines · Dave Jones

This is probably useless on x86 for eg..
(Everything else in this file is dependant on some other s390 feature,
so only this one shows up). Too bad the drivers/s390/block stuff gets
source'd at all on !s390.

Doesn't the config language support wrapping the entire KConfig file (or even a higher level one) with "if ARCH_S390"? All that does is add a "depends ARCH_S390" to everything in the file, but it would sure be a lot easier to maintain.

author
#2 lore raw
Quoted 11 lines · Kevin P. Fleming
Quoted 4 lines · Dave Jones

This is probably useless on x86 for eg..
(Everything else in this file is dependant on some other s390 feature, so only this one shows up). Too bad the drivers/s390/block stuff gets source'd at all on !s390.

Doesn't the config language support wrapping the entire KConfig file (or even a higher level one) with "if ARCH_S390"? All that does is add a "depends ARCH_S390" to everything in the file, but it would sure be a lot easier to maintain.

Sure, you force a bool to y if ARCH=S390 at the top. That would work. Probably.

Dave

author
#3 lore raw
Quoted 6 lines · Dave Jones
Quoted 3 lines

even a higher level one) with "if ARCH_S390"? All that does is add a "depends ARCH_S390" to everything in the file, but it would sure be a lot easier to maintain.

Sure, you force a bool to y if ARCH=S390 at the top. That would work. Probably.

Or even easier..
(Seems to do the right thing on x86 and make menuconfig ARCH=s390

Dave

drivers/s390/block/Kconfig renamed from drivers/s390/block/Kconfig~ +4 -0
@@ -1,3 +1,5 @@
+if ARCH_S390
+
 comment "S/390 block device drivers"
 	depends on ARCH_S390
 
@@ -62,3 +64,5 @@
 	  ioctl functions specific to the dasd driver.
 	  This is only needed if you want to use applications written for
 	  linux-2.4 dasd channel measurement facility interface.
+
+endif
#4 lore raw

drivers/s390/block/Kconfig line 4

Quoted 7 lines · Dave Jones
drivers/s390/block/Kconfig renamed from drivers/s390/block/Kconfig~ +2 -0
@@ -1,3 +1,5 @@
+if ARCH_S390
+
 comment "S/390 block device drivers"
 	depends on ARCH_S390
                    ^^^

But this is now redundant :-)