Skip to contentSkip to conversation

Add a MODULE_VERSION macro

PATCH Petr Vandrovec 2 participants 3 messages Feb 27, 2004 – Mar 1, 2004 Kbuild

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines · Linux Kernel Mailing List

ChangeSet 1.1713, 2004/02/26 22:51:58-08:00, [email protected]

[PATCH] Add a MODULE_VERSION macro

...

Quoted 4 lines

diff -Nru a/scripts/Makefile.modpost b/scripts/Makefile.modpost

scripts/Makefile.modpost Thu Feb 26 23:11:35 2004 +0 -0
@@ -10,10 +10,11 @@

...

Quoted 6 lines

ifneq ($(filter-out $(modules),$(__modules)),)
+ $(warning Trouble: $(__modules) )
$(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
$(warning do not complain if something goes wrong.)
endif

Hi Rusty,
what is this line supposed to do, except making it impossible
to build kernel modules in temporary directories? Now when I build out-of-tree modules, I get 'Trouble:' followed by approximate 16000 characters listing paths to all modules I have in kernel, for no apparent reason (I know that I removed some module I built in /tmp... why kernel should care, that module is gone forever), so it makes all warning & error messages completely lost 5 screens away.

Can you remove this 'Trouble:' message, or at least provide some
way to disable that message (and two warnings below it too, they serve no useful purpose AFAICT, as they trigger whenever you'll remove some module from directory where you built it) ? Or at least make it
useful: print only modules which are missing, not all modules.
Thanks,
Petr Vandrovec

#1 lore raw

In message <[email protected]> you write:

Quoted 11 lines
Quoted 5 lines

ifneq ($(filter-out $(modules),$(__modules)),)
+ $(warning Trouble: $(__modules) )
$(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
$(warning do not complain if something goes wrong.)
endif

Hi Rusty,
what is this line supposed to do, except making it impossible
to build kernel modules in temporary directories? Now when I build out-of-tree modules, I get 'Trouble:' followed by approximate 16000 characters listing paths to all modules I have in kernel

Patch below: does it help?

Rusty
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

scripts/Makefile.modpost +1 -1
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.4-rc1-bk1/scripts/Makefile.modpost tmp/scripts/Makefile.modpost
@@ -14,7 +14,7 @@ __modules := $(shell head -q -n1 /dev/nu
 modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o)))
 
 ifneq ($(filter-out $(modules),$(__modules)),)
-  $(warning Trouble: $(__modules) )
+  $(warning Trouble: $(filter-out $(modules),$(__modules)))
   $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
   $(warning     do not complain if something goes wrong.)
 endif
#2 lore raw
Quoted 1 line · Rusty Russell

Patch below: does it help?

Yes, much better:

/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:17: Trouble: /tmp/vmware-config1/vmnet-only/vmnet.ko
/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:18: *** Uh-oh, you have stale module entries. You messed with SUBDIRS,/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:19: do not complain if something goes wrong.

Thanks,
Petr Vandrovec

Quoted 18 lines

Rusty
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.4-rc1-bk1/scripts/Makefile.modpost tmp/scripts/Makefile.modpost

scripts/Makefile.modpost +1 -1
@@ -14,7 +14,7 @@ __modules := $(shell head -q -n1 /dev/nu
 modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o)))
 
 ifneq ($(filter-out $(modules),$(__modules)),)
-  $(warning Trouble: $(__modules) )
+  $(warning Trouble: $(filter-out $(modules),$(__modules)))
   $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
   $(warning     do not complain if something goes wrong.)
 endif