Compile kernel with GCC-3.5 and without regparm
PATCH 1/1 Compile kernel with GCC-3.5 and without regparm
Hi.
I tried to build the kernel with my CVS GCC-3.5 compiler today, and had all sorts of failures about prototypes not matching. My configuration had not selected the 'CONFIG_REGPARM' option, so the new '-mregparm=3' flag wasn't passed to the compiler. That's fine, but the problem is the FASTCALL macro is unconditionally defined to add an regparm(3) attribute, making the compiler quite confused. The following small patch conditionally defines FASTCALL, and allowed my compilation to succeed either with or without the CONFIG_REGPARM conditional being defined.
I tested this patch by configuring a kernel without the CONFIG_REGPARM flag, then started the build. Once the build got through building a couple of files in 'arch/i386/kernel' that had failed previously, I stopped the build. A cleanup and reconfiguration with the CONFIG_REGPARM conditional followed, and a new build began. Again, the files in the same directory compiled fine, so things looked good. I then tried to build with CONFIG_REGPARM defined and setting CC and HOSTCC to use my gcc-2.95 compiler, and the files in that directory compiled again successfully once more.
If this patch is deemed correct, a similar patch for 'asm-um' is likely necessary as well.
Art Haas
===== include/asm-i386/linkage.h 1.2 vs edited =====
include/asm-i386/linkage.h +2 -0
@@ -2,7 +2,9 @@#define __ASM_LINKAGE_H#define asmlinkage CPP_ASMLINKAGE __attribute__((regparm(0))) +#ifdef CONFIG_REGPARM #define FASTCALL (x) x __attribute__((regparm(3))) +#endif #ifdef CONFIG_X86_ALIGNMENT_16 #define __ALIGN .align 16,0x90
Signature · 4 lines
Man once surrendering his reason, has no remaining guard against absurdities the most monstrous, and like a ship without rudder, is the sport of every wind. -Thomas Jefferson to James Smith, 1822
Quoted 3 lines · Art Haas
I tried to build the kernel with my CVS GCC-3.5 compiler today, and had all sorts of failures about prototypes not matching.
-mm is where the gcc-3.5 action is. There seems to be a bit of an arms race going on wherein the gcc developers are trying to break the kernel build faster than I and others can fix it.
See the fastcall-* patches.
Quoted 30 lines · Art Haas
Hi.
I tried to build the kernel with my CVS GCC-3.5 compiler today, and had all sorts of failures about prototypes not matching. My configuration had not selected the '
CONFIG_REGPARM' option, so the new '-mregparm=3' flag wasn't passed to the compiler. That's fine, but the problem is the FASTCALL macro is unconditionally defined to add an regparm(3) attribute, making the compiler quite confused. The following small patch conditionally defines FASTCALL, and allowed my compilation to succeed either with or without theCONFIG_REGPARMconditional being defined.I tested this patch by configuring a kernel without the
CONFIG_REGPARMflag, then started the build. Once the build got through building a couple of files in 'arch/i386/kernel' that had failed previously, I stopped the build. A cleanup and reconfiguration with theCONFIG_REGPARMconditional followed, and a new build began. Again, the files in the same directory compiled fine, so things looked good. I then tried to build withCONFIG_REGPARMdefined and setting CC and HOSTCC to use my gcc-2.95 compiler, and the files in that directory compiled again successfully once more.If this patch is deemed correct, a similar patch for 'asm-um' is likely necessary as well.
Art Haas
=====
include/asm-i386/linkage.h1.2 vs edited =====
include/asm-i386/linkage.h line 10
Quoted 9 lines
include/asm-i386/linkage.h +2
-0@@ -2,7 +2,9 @@#define __ASM_LINKAGE_H#define asmlinkage CPP_ASMLINKAGE __attribute__((regparm(0))) +#ifdef CONFIG_REGPARM #define FASTCALL (x) x __attribute__((regparm(3))) +#endif #ifdef CONFIG_X86_ALIGNMENT_16 #define __ALIGN .align 16,0x90
You can't do this. Some of these functions are called from asm code which assumes that parameters are passed in registers. The right fix is to make the prototypes and function match.
--
Brian Gerst