Skip to contentSkip to conversation

linux-2.5 cset 1.1654.1.2 xfs filemap_flush() unresolved

DISCUSSION Olaf Hering 2 participants 2 messages Mar 7, 2004 – Mar 8, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

filemap_flush() is not an exported symbol, at least not in my tree.

Quoted 41 lines

ChangeSet
1.1654.1.2 04/03/06 14:47:10 [email protected] +1 -0
[XFS] Fix out-of-space deadlock when flushing delalloc data with pages locked under write.

SGI Modid: xfs-linux:xfs-kern:167948a

fs/xfs/linux/xfs_super.c
1.70 04/03/06 14:46:51 [email protected] +1 -1
[XFS] Fix out-of-space deadlock when flushing delalloc data with pages locked under write.

.........................................................................
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas:
# ChangeSet 1.1654.1.1 -> 1.1654.1.2
# fs/xfs/linux/xfs_super.c 1.69 -> 1.70
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/03/06 [email protected] 1.1654.1.2
# [XFS] Fix out-of-space deadlock when flushing delalloc data with pages locked under write. #
# SGI Modid: xfs-linux:xfs-kern:167948a
# --------------------------------------------
#
diff -Nru a/fs/xfs/linux/xfs_super.c b/fs/xfs/linux/xfs_super.c

fs/xfs/linux/xfs_super.c +1 -1
@@ -247,7 +247,7 @@
 {
 	struct inode	*inode = LINVFS_GET_IP(XFS_ITOV(ip));
 
-	filemap_fdatawrite(inode->i_mapping);
+	filemap_flush(inode->i_mapping);
 }
 
 void
.........................................................................

# vim: syntax=diff

Signature · 3 lines
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG
#2 lore raw
Quoted 3 lines · Olaf Hering

filemap_flush() is not an exported symbol, at least not in my tree.

Thanks Olaf,

Trivial fix follows (for modular XFS builds).

cheers.

Signature · 14 lines
Nathan


--- mm/filemap.c.orig	2004-03-08 19:44:18.904099904 +1100
+++ mm/filemap.c	2004-03-08 19:44:45.641035272 +1100
@@ -168,6 +168,8 @@
 	return __filemap_fdatawrite(mapping, WB_SYNC_NONE);
 }
 
+EXPORT_SYMBOL(filemap_flush);
+
 /**
  * filemap_fdatawait - walk the list of locked pages of the given address
  *                     space and wait for all of them.