2.6.4-mm1
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 10 lines · Joe Thornber
Fix ioctl breakage on x86-64.
include/linux/dm-ioctl.h +3
-0@@ -187,23 +187,37 @@ enum { DM_TABLE_STATUS_CMD, }; +/* +* The dm_ioctl struct passed into the ioctl is just the header +* on a larger chunk of memory. On x86-64 the dm-ioctl struct
include/linux/dm-ioctl.h enum { · line 202
Quoted 10 lines
include/linux/dm-ioctl.h +10
-0+* will be padded to an 8 byte boundary so the size will be +* different, which would change the ioctl code - yes I really +* messed up. This hack forces x86-64 to have the correct ioctl +* code. +*/ +#ifdef CONFIG_X86_64 +typedef char ioctl_struct [308 ]; +#else +typedef struct dm_ioctl ioctl_struct ; +#endif
That's bad because it will break binary compatibility for existing x86-64 systems. Don't add that please. Either emulate it properly or I will just declare the 32bit DM emulation broken and users will have to live with that.
-Andi
Quoted 4 lines · Andi Kleen
That's bad because it will break binary compatibility for existing x86-64 systems. Don't add that please. Either emulate it properly or I will just declare the 32bit DM emulation broken and users will have to live with that.
So you want me to put in a seperate set of ioctl codes for compatibility ?
- Joe
Quoted 8 lines · Joe Thornber
Quoted 4 lines · Andi Kleen
That's bad because it will break binary compatibility for existing x86-64 systems. Don't add that please. Either emulate it properly or I will just declare the 32bit DM emulation broken and users will have to live with that.
So you want me to put in a seperate set of ioctl codes for compatibility.
Breaking the 64bit ABI is not acceptable at least. There are distributions shipping that use it.
For 32bit emulation you can use what you think is easiest or just ignore it if it's too hard (64bit is more important than 32bit)
-Andi
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 4 lines · Joe Thornber
Quoted 2 lines
good candidate for next mm ?
Yep, I'll forward a patch to akpm now.
Please don't do that. It will break all 64bit userland.
-Andi