Skip to contentSkip to conversation

Revised fix for show_mem panic

PATCH John Marvin 1 participant 1 message Mar 15, 2004

lore
Share & tools
lore
#0 lore raw

Oops. Usually I forget to include the patch. This time I sent the patch without the intro text:

Quoted 2 lines

Would it make sense to do only the first __get_user() _unless_ the "struct page" crosses a page?

Most likely. Although code that calls ia64_pfn_valid is going to be dereferencing the page structure anyway, a page structure will always cross a 1st level cache line, and will often cross a second level cache line. The code may or may not touch both parts of the the structure, so the test may prevent an unecessary cache line load, and it won't take that many cycles to test for the case.

John