Skip to contentSkip to conversation

Don't leave crap in /sys after module exit.

PATCH New [email protected] 1 participant 1 message Mar 15, 2004 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 6/6 Don't leave crap in /sys after module exit.

Here's a fun one. modprobe snd_dt019x.c when you don't have the hardware. It fails to detect as expected, but doesn't stay around, so you don't even need to rmmod it afterwards. Unfortunatly, it leaves around crap in /sys/bus/pnp/drivers/dt019x which buggers up any subsequent usage of the pnp code. Fix is easy : Keep the module around even when things fail.

Dave

sound/isa/dt019x.c renamed from sound/isa/dt019x.c~ +1 -1
@@ -325,7 +325,7 @@
 	if (!cards)
 		snd_printk(KERN_ERR "no DT-019X / ALS-007 based soundcards found\n");
 #endif
-	return cards ? 0 : -ENODEV;
+	return cards < 0 ? cards : 0;
 }
 
 static void __exit alsa_card_dt019x_exit(void)