Skip to contentSkip to conversation

don't support %n in printk

PATCH/RFC Muli Ben-Yehuda 2 participants 2 messages Mar 20, 2004 – Apr 2, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

The printf man page has this to say about '%n':

"The number of characters written so far is stored into the integer
indicated by the int * (or variant) pointer argument. No argument
is converted."

Very little code actually uses %n for that. Now days, %n has a much more common use - in printf format string exploits. Since no kernel code appears to be using %n (thus said grep), this patch removes support for it. To preempt the obvious argument, I agree that printk should look and behave as much as possible as printf - except where it's harmful. We don't support floating point, for example, and I doubt we should support %n - although I don't strongly care one way or another.

lib/vsprintf.c +3 -16
diff -Naurp -X /home/muli/w/dontdiff linux-2.5/lib/vsprintf.c no-n-percent/lib/vsprintf.c
@@ -14,6 +14,9 @@
  * - changed to provide snprintf and vsnprintf functions
  * So Feb  1 16:51:32 CET 2004 Juergen Quade <[email protected]>
  * - scnprintf and vscnprintf
+ * Sat Mar 20 22:38:09 2004 Muli Ben-Yehuda <[email protected]>
+ * - remove '%n' support from vsnprintf, as nothing is using it, and it 
+ *   has very few legitimate uses (and many many illegitimate ones)
  */
 
 #include <stdarg.h>
@@ -401,22 +404,6 @@ int vsnprintf(char *buf, size_t size, co
 						16, field_width, precision, flags);
 				continue;
 
-
-			case 'n':
-				/* FIXME:
-				* What does C99 say about the overflow case here? */
-				if (qualifier == 'l') {
-					long * ip = va_arg(args, long *);
-					*ip = (str - buf);
-				} else if (qualifier == 'Z' || qualifier == 'z') {
-					size_t * ip = va_arg(args, size_t *);
-					*ip = (str - buf);
-				} else {
-					int * ip = va_arg(args, int *);
-					*ip = (str - buf);
-				}
-				continue;
-
 			case '%':
 				if (str <= end)
 					*str = '%';

Cheers,
Muli

Signature · 2 lines
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/
#1 lore raw

Hi!

Quoted 6 lines

The printf man page has this to say about '%n':

"The number of characters written so far is stored into the integer
indicated by the int * (or variant) pointer argument. No argument
is converted."

Quoted 8 lines

Very little code actually uses %n for that. Now days, %n has a much more common use - in printf format string exploits. Since no kernel code appears to be using %n (thus said grep), this patch removes support for it. To preempt the obvious argument, I agree that printk should look and behave as much as possible as printf - except where it's harmful. We don't support floating point, for example, and I doubt we should support %n - although I don't strongly care one way or another.

You probably should search the kernel for any uses of %n and fix them...
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]