Skip to contentSkip to conversation

Makefile dependancies: scripts depending on configured kernel?

DISCUSSION Michael Still 2 participants 3 messages Mar 21, 2004 – Mar 22, 2004

lore
Share & tools
lore
#0 lore raw

Hey,

the top level Makefile specifies that the scripts depend on the kernel being configured before the scripts can be built:

scripts: scripts_basic include/config/MARKER

	$(Q)$(MAKE) $(build)=$(@)

I think that this is probably a problem, because it means people can't build any of the documentation targets without having configured the kernel.

Do any of the scripts actually depend on a configured kernel to build? How can I verify that none of them need a configured kernel? Commenting out the dependancy didn't break anything.

Thanks,
Mikal

Signature · 3 lines
Michael Still ([email protected]) | "All my life I've had one dream,
http://www.stillhq.com            |  to achieve my many goals"
UTC + 11                          |    -- Homer Simpson
#1 lore raw
Quoted 11 lines · Michael Still

Hey,

the top level Makefile specifies that the scripts depend on the kernel being configured before the scripts can be built:

scripts: scripts_basic include/config/MARKER

	$(Q)$(MAKE) $(build)=$(@)

I think that this is probably a problem, because it means people can't build any of the documentation targets without having configured the kernel.

The dependency for docs is (now) wrong.
It should be:
# Documentation targets
# --------------------------------------------------------------------------- %docs: scripts_basic FORCE

        $(Q)$(MAKE) $(build)=Documentation/DocBook $@

docproc is the only binary used by Documentation/Docbook, and it is already placed in scripts_basic.

Trivial - so I will include this in some other kbuild patch I'm preparing.

Quoted 1 line

Do any of the scripts actually depend on a configured kernel to build?

Yes, several of the ninaries do so. Among others empty.o.

Quoted 2 lines

How can I verify that none of them need a configured kernel? Commenting out the dependancy didn't break anything.

Test a bit more, and you will see they are indeed needed. Note, some archs other than i386 have a bit different requirements because thay do not use an asm-offsett.h file.

Sam

#2 lore raw
Quoted 9 lines · Sam Ravnborg

The dependency for docs is (now) wrong.
It should be:
# Documentation targets
# --------------------------------------------------------------------------- %docs: scripts_basic FORCE

        $(Q)$(MAKE) $(build)=Documentation/DocBook $@

docproc is the only binary used by Documentation/Docbook, and it is already placed in scripts_basic.

True.

Quoted 2 lines

Trivial - so I will include this in some other kbuild patch I'm preparing.

Cool, it will be nice to have this working out of the box again.

Quoted 3 lines

Test a bit more, and you will see they are indeed needed. Note, some archs other than i386 have a bit different requirements because thay do not use an asm-offsett.h file.

Interesting. I built most of the targets and they still worked. I'm happy to accept that it's needed though.

Cheers,
Mikal

Signature · 3 lines
Michael Still ([email protected]) | "All my life I've had one dream,
http://www.stillhq.com            |  to achieve my many goals"
UTC + 11                          |    -- Homer Simpson