[PATCH] Prevent oops in nfs_sb_init

Olaf Kirch

author

2004-03-23 10:19 UTC #0 lore raw

PATCH 1/1 Prevent oops in nfs_sb_init

nfs_sb_init will crash when the fsinfo call fails, because it tries to iput() an uninitialized pointer. The attached patch should fix this.

Olaf

Signature · 3 lines

Olaf Kirch     |  Stop wasting entropy - start using predictable
[email protected]   |  tempfile names today!
---------------+

fs/nfs/inode.c renamed from fs/nfs/inode.c.orig +2 -2

@@ -277,7 +277,7 @@
 nfs_sb_init(struct super_block *sb, rpc_authflavor_t authflavor)
 {
 	struct nfs_server	*server;
-	struct inode		*root_inode;
+	struct inode		*root_inode = NULL;
 	struct nfs_fattr	fattr;
 	struct nfs_fsinfo	fsinfo = {
 					.fattr = &fattr,

@@ -361,7 +361,7 @@
 	/* Yargs. It didn't work out. */
 out_no_root:
 	printk("nfs_read_super: get root inode failed\n");
-	if (!IS_ERR(root_inode))
+	if (root_inode && !IS_ERR(root_inode))
 		iput(root_inode);
 	return -EINVAL;
 }

Trond Myklebust

2004-03-23 16:00 UTC #1 lore raw

P=E5 ty , 23/03/2004 klokka 05:17, skreiv Olaf Kirch:

Quoted 3 lines

nfs_sb_init will crash when the fsinfo call fails, because it tries to iput() an uninitialized pointer. The attached patch should fix this.

This bug should already be fixed in 2.6.5-rc2...

Cheers,
Trond

-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Olaf Kirch

author

2004-03-23 16:23 UTC #2 lore raw

Quoted 6 lines · Trond Myklebust

P=E5 ty , 23/03/2004 klokka 05:17, skreiv Olaf Kirch:
Quoted 3 lines
nfs_sb_init will crash when the fsinfo call fails, because it tries to iput() an uninitialized pointer. The attached patch should fix this.
=20
This bug should already be fixed in 2.6.5-rc2...

Ah, good to know.

Thanks,
Olaf
--=20

Olaf Kirch     |  Stop wasting entropy - start using predictable
[email protected]   |  tempfile names today!

---------------+=20

-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs