PATCH: siginfo -> si_band is long
Hi,
After discussion on the glibc list the result was that si_band is "long int" according to POSIX:
http://www.opengroup.org/onlinepubs/007904975/basedefs/signal.h.html
Ulrich Drepper refused a patch to fix glibc due to this reason:
http://sources.redhat.com/ml/libc-alpha/2004-03/msg00254.html
so here is the patch to fix it in the kernel.
ppc64 and s390x were broken before and are fixed by this patch too.
Please apply.
Ciao, Marcus
include/asm-generic/siginfo.h renamed from include/asm-generic/siginfo.h.xx +1 -1
@@ -27,7 +27,7 @@#endif #ifndef __ARCH_SI_BAND_T -#define __ARCH_SI_BAND_T int +#define __ARCH_SI_BAND_T long int#endif #ifndef HAVE_ARCH_SIGINFO_T
include/asm-x86_64/siginfo.h renamed from include/asm-x86_64/siginfo.h.xx +0 -2
@@ -3,8 +3,6 @@#define __ARCH_SI_PREAMBLE_SIZE (4 * sizeof(int)) -#define __ARCH_SI_BAND_T long -#define SIGEV_PAD_SIZE ((SIGEV_MAX_SIZE/sizeof(int)) - 4)#include <asm-generic/siginfo.h>
Ciao, Marcus
On 2004-03-24T14:57:37,
Marcus Meissner <[email protected]> said:
Hi Andrew, the patch looks good to me (I originally stumbled across this when debugging an application trying to use SIGIO, which is currently broken on ppc64).
Could you please pick it up?
s390x, sparc64 might also be affected, btw.
Why are all these archs not using the asm-generic/siginfo.h anyway? *sigh*. Oh well.
Quoted 41 lines
Hi,
After discussion on the glibc list the result was that
si_bandis "long int" according to POSIX:http://www.opengroup.org/onlinepubs/007904975/basedefs/signal.h.htmlUlrich Drepper refused a patch to fix glibc due to this reason:
http://sources.redhat.com/ml/libc-alpha/2004-03/msg00254.htmlso here is the patch to fix it in the kernel.
ppc64 and s390x were broken before and are fixed by this patch too.
Please apply.
Ciao, Marcus
include/asm-generic/siginfo.h renamed from include/asm-generic/siginfo.h.xx +1
-1@@ -27,7 +27,7 @@#endif #ifndef __ARCH_SI_BAND_T -#define __ARCH_SI_BAND_T int +#define __ARCH_SI_BAND_T long int#endif #ifndef HAVE_ARCH_SIGINFO_T include/asm-x86_64/siginfo.h renamed from include/asm-x86_64/siginfo.h.xx +0
-2@@ -3,8 +3,6 @@#define __ARCH_SI_PREAMBLE_SIZE (4 * sizeof(int)) -#define __ARCH_SI_BAND_T long -#define SIGEV_PAD_SIZE ((SIGEV_MAX_SIZE/sizeof(int)) - 4)#include <asm-generic/siginfo.h>
Quoted 1 line
Ciao, Marcus
Sincerely,
Lars Marowsky-Brée <[email protected]>
Signature · 3 lines
High Availability & Clustering \ ever tried. ever failed. no matter. SUSE Labs | try again. fail again. fail better. Research & Development, SUSE LINUX AG \ -- Samuel Beckett