Skip to contentSkip to conversation

2.6.5-rc2-mm4

DISCUSSION Dan Hopper 2 participants 3 messages Mar 28, 2004 – Mar 29, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dan Hopper

author
#1 lore raw

Andrew Morton <[email protected]> remarked:

Quoted 3 lines

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.5-rc2/2.6.5-rc2-mm4/

Hi Andrew,

On a Thinkpad T40p, 2.6.5-rc2-mm4 does not boot successfully, whereas 2.6.5-rc2 does. All the typical things (ACPI, CPUFREQ, APIC & IOAPIC, etc.) are built in. The -mm4 kernel config was derived from the working config for 2.6.5-rc2.

I have to pass the nolapic kernel option to disable the local APIC in order to successfully boot 2.6.x kernels. It appears that with 2.6.5-rc2-mm4, this option is ignored, or perhaps there's a ordering issue with when it is checked. With -mm4, a message saying that it is enabling the local APIC appears _before_ the "Kernel command
line: ... nolapic" line appears.

Without the -mm4 patch, the nolapic command line option is parsed before it would have tried to reenable the local APIC. With -mm4, it is parsed after it tries to renable it. Boom, and then it locks on "Calibrating delay loop...".

Any relevant config options I should try with/without to help narrow it down?

Thanks,
Dan

#2 lore raw
Quoted 13 lines · Dan Hopper

On a Thinkpad T40p, 2.6.5-rc2-mm4 does not boot successfully,
whereas 2.6.5-rc2 does. All the typical things (ACPI, CPUFREQ, APIC & IOAPIC, etc.) are built in. The -mm4 kernel config was derived from the working config for 2.6.5-rc2.

I have to pass the nolapic kernel option to disable the local APIC in order to successfully boot 2.6.x kernels. It appears that with 2.6.5-rc2-mm4, this option is ignored, or perhaps there's a ordering issue with when it is checked. With -mm4, a message saying that it is enabling the local APIC appears _before_ the "Kernel command
line: ... nolapic" line appears.

Quoted 7 lines

Without the -mm4 patch, the nolapic command line option is parsed before it would have tried to reenable the local APIC. With -mm4, it is parsed after it tries to renable it. Boom, and then it locks on "Calibrating delay loop...".

Any relevant config options I should try with/without to help narrow it down?

Does this fix it?

---

 25-akpm/arch/i386/kernel/apic.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
arch/i386/kernel/apic.c renamed from arch/i386/kernel/apic.c~early-param-i386-nolapic-fix +1 -1
diff -puN arch/i386/kernel/apic.c~early-param-i386-nolapic-fix arch/i386/kernel/apic.c
@@ -616,7 +616,7 @@ static int __init lapic_disable(char *st
 	clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
 	return 0;
 }
-__setup("nolapic", lapic_disable);
+__early_param("nolapic", lapic_disable);
 
 static int __init lapic_enable(char *str)
 {

_

author
#3 lore raw

Andrew Morton <[email protected]> remarked:

Quoted 19 lines
Quoted 18 lines · Dan Hopper

On a Thinkpad T40p, 2.6.5-rc2-mm4 does not boot successfully,
whereas 2.6.5-rc2 does. All the typical things (ACPI, CPUFREQ, APIC & IOAPIC, etc.) are built in. The -mm4 kernel config was derived from the working config for 2.6.5-rc2.

I have to pass the nolapic kernel option to disable the local APIC in order to successfully boot 2.6.x kernels. It appears that with 2.6.5-rc2-mm4, this option is ignored, or perhaps there's a ordering issue with when it is checked. With -mm4, a message saying that it is enabling the local APIC appears _before_ the "Kernel command
line: ... nolapic" line appears.

Without the -mm4 patch, the nolapic command line option is parsed before it would have tried to reenable the local APIC. With -mm4, it is parsed after it tries to renable it. Boom, and then it locks on "Calibrating delay loop...".

Quoted 4 lines
Quoted 2 lines

Any relevant config options I should try with/without to help narrow it down?

Does this fix it?

Yep, it sure does. Thanks!

Dan

Quoted 21 lines

---

 25-akpm/arch/i386/kernel/apic.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/i386/kernel/apic.c~early-param-i386-nolapic-fix arch/i386/kernel/apic.c

arch/i386/kernel/apic.c renamed from arch/i386/kernel/apic.c~early-param-i386-nolapic-fix +1 -1
@@ -616,7 +616,7 @@ static int __init lapic_disable(char *st
 	clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
 	return 0;
 }
-__setup("nolapic", lapic_disable);
+__early_param("nolapic", lapic_disable);
 
 static int __init lapic_enable(char *str)
 {

_