Skip to contentSkip to conversation

eliminate nswap and cnswap

PATCH New Matt Mackall 1 participant 1 message Apr 3, 2004

Subsystems (5)
MM core Scheduler exec and binfmt Proc filesystem +1 more subsystems
lore
Share & tools
lore

Matt Mackall

author
#0 lore raw

PATCH 1/1 eliminate nswap and cnswap

The nswap and cnswap variables counters have never been incremented as Linux doesn't do task swapping.

 tiny-mpm/arch/alpha/kernel/osf_sys.c |    3 ---
 tiny-mpm/fs/proc/array.c             |    4 ++--
 tiny-mpm/include/linux/sched.h       |    2 +-
 tiny-mpm/kernel/acct.c               |    2 +-
 tiny-mpm/kernel/exit.c               |    1 -
 tiny-mpm/kernel/fork.c               |    1 -
 tiny-mpm/kernel/sys.c                |    3 ---
 7 files changed, 4 insertions(+), 12 deletions(-)
arch/alpha/kernel/osf_sys.c renamed from arch/alpha/kernel/osf_sys.c~kill-nswap +0 -3
diff -puN arch/alpha/kernel/osf_sys.c~kill-nswap arch/alpha/kernel/osf_sys.c
@@ -1095,14 +1095,12 @@ osf_getrusage(int who, struct rusage32 *
 		jiffies_to_timeval32(current->stime, &r.ru_stime);
 		r.ru_minflt = current->min_flt;
 		r.ru_majflt = current->maj_flt;
-		r.ru_nswap = current->nswap;
 		break;
 	case RUSAGE_CHILDREN:
 		jiffies_to_timeval32(current->cutime, &r.ru_utime);
 		jiffies_to_timeval32(current->cstime, &r.ru_stime);
 		r.ru_minflt = current->cmin_flt;
 		r.ru_majflt = current->cmaj_flt;
-		r.ru_nswap = current->cnswap;
 		break;
 	default:
 		jiffies_to_timeval32(current->utime + current->cutime,

@@ -1111,7 +1109,6 @@ osf_getrusage(int who, struct rusage32 *
 				   &r.ru_stime);
 		r.ru_minflt = current->min_flt + current->cmin_flt;
 		r.ru_majflt = current->maj_flt + current->cmaj_flt;
-		r.ru_nswap = current->nswap + current->cnswap;
 		break;
 	}
fs/proc/array.c renamed from fs/proc/array.c~kill-nswap +2 -2
diff -puN fs/proc/array.c~kill-nswap fs/proc/array.c
@@ -388,8 +388,8 @@ int proc_pid_stat(struct task_struct *ta
 		sigign      .sig[0] & 0x7fffffffUL,
 		sigcatch    .sig[0] & 0x7fffffffUL,
 		wchan,
-		task->nswap,
-		task->cnswap,
+		0UL,
+		0UL,
 		task->exit_signal,
 		task_cpu(task),
 		task->rt_priority,
include/linux/sched.h renamed from include/linux/sched.h~kill-nswap +1 -1
diff -puN include/linux/sched.h~kill-nswap include/linux/sched.h
@@ -428,7 +428,7 @@ struct task_struct {
 	unsigned long nvcsw, nivcsw, cnvcsw, cnivcsw; /* context switch counts */
 	u64 start_time;
 /* mm fault and swap info: this can arguably be seen as either mm-specific or thread-specific */
-	unsigned long min_flt, maj_flt, nswap, cmin_flt, cmaj_flt, cnswap;
+	unsigned long min_flt, maj_flt, cmin_flt, cmaj_flt;
 /* process credentials */
 	uid_t uid,euid,suid,fsuid;
 	gid_t gid,egid,sgid,fsgid;
kernel/acct.c renamed from kernel/acct.c~kill-nswap +1 -1
diff -puN kernel/acct.c~kill-nswap kernel/acct.c
@@ -376,7 +376,7 @@ static void do_acct_process(long exitcod
 	ac.ac_rw = encode_comp_t(ac.ac_io / 1024);
 	ac.ac_minflt = encode_comp_t(current->min_flt);
 	ac.ac_majflt = encode_comp_t(current->maj_flt);
-	ac.ac_swaps = encode_comp_t(current->nswap);
+	ac.ac_swaps = encode_comp_t(0);
 	ac.ac_exitcode = exitcode;
 
 	/*
kernel/exit.c renamed from kernel/exit.c~kill-nswap +0 -1
diff -puN kernel/exit.c~kill-nswap kernel/exit.c
@@ -92,7 +92,6 @@ repeat: 
 	p->parent->cstime += p->stime + p->cstime;
 	p->parent->cmin_flt += p->min_flt + p->cmin_flt;
 	p->parent->cmaj_flt += p->maj_flt + p->cmaj_flt;
-	p->parent->cnswap += p->nswap + p->cnswap;
 	p->parent->cnvcsw += p->nvcsw + p->cnvcsw;
 	p->parent->cnivcsw += p->nivcsw + p->cnivcsw;
 	sched_exit(p);
kernel/fork.c renamed from kernel/fork.c~kill-nswap +0 -1
diff -puN kernel/fork.c~kill-nswap kernel/fork.c
@@ -512,7 +512,6 @@ static int copy_mm(unsigned long clone_f
 
 	tsk->min_flt = tsk->maj_flt = 0;
 	tsk->cmin_flt = tsk->cmaj_flt = 0;
-	tsk->nswap = tsk->cnswap = 0;
 	tsk->nvcsw = tsk->nivcsw = tsk->cnvcsw = tsk->cnivcsw = 0;
 
 	tsk->mm = NULL;
kernel/sys.c renamed from kernel/sys.c~kill-nswap +0 -3
diff -puN kernel/sys.c~kill-nswap kernel/sys.c
@@ -1521,7 +1521,6 @@ int getrusage(struct task_struct *p, int
 			r.ru_nivcsw = p->nivcsw;
 			r.ru_minflt = p->min_flt;
 			r.ru_majflt = p->maj_flt;
-			r.ru_nswap = p->nswap;
 			break;
 		case RUSAGE_CHILDREN:
 			jiffies_to_timeval(p->cutime, &r.ru_utime);

@@ -1530,7 +1529,6 @@ int getrusage(struct task_struct *p, int
 			r.ru_nivcsw = p->cnivcsw;
 			r.ru_minflt = p->cmin_flt;
 			r.ru_majflt = p->cmaj_flt;
-			r.ru_nswap = p->cnswap;
 			break;
 		default:
 			jiffies_to_timeval(p->utime + p->cutime, &r.ru_utime);

@@ -1539,7 +1537,6 @@ int getrusage(struct task_struct *p, int
 			r.ru_nivcsw = p->nivcsw + p->cnivcsw;
 			r.ru_minflt = p->min_flt + p->cmin_flt;
 			r.ru_majflt = p->maj_flt + p->cmaj_flt;
-			r.ru_nswap = p->nswap + p->cnswap;
 			break;
 	}
 	return copy_to_user(ru, &r, sizeof(r)) ? -EFAULT : 0;

_

Signature · 1 line
Matt Mackall : http://www.selenic.com : Linux development and consulting