Skip to contentSkip to conversation

eliminate divert_blk message

PATCH In review Olaf Kirch 2 participants 3 messages Apr 5, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Olaf Kirch

author
#0 lore raw

PATCH 1/1 eliminate divert_blk message

Every time a non-ethernet device is configured (e.g. when using PPP) the kernel logs a message saying "not allocating divert_blk for non-ethernet device". This patch disables the message.

Cheers,
Olaf

Signature · 3 lines
Olaf Kirch     |  The Hardware Gods hate me.
[email protected]   |
---------------+
net/core/dv.c renamed from net/core/dv.c.quiet +0 -3
@@ -67,9 +67,6 @@
 		}
 		dev_hold(dev);
 	} else {
-		printk(KERN_DEBUG "divert: not allocating divert_blk for non-ethernet device %s\n",
-		       dev->name);
-
 		dev->divert = NULL;
 	}
 	return 0;
#1 lore raw
Quoted 3 lines · On Mon, 5 Apr 2004 17:03:12 +0200 Olaf Kirch <[email protected]> wrote:

Every time a non-ethernet device is configured (e.g. when using PPP) the kernel logs a message saying "not allocating divert_blk for non-ethernet device". This patch disables the message.

Are you sure? All our kernels have CONFIG_NET_DIVERT disabled. I don't see how you could get this message unless you enabled it on your own. If you did that just disable it, it's imho an useless option.

-Andi

#2 lore raw
Quoted 10 lines · On Mon, 5 Apr 2004 18:19:25 +0200 Andi Kleen <[email protected]> wrote:
Quoted 3 lines · On Mon, 5 Apr 2004 17:03:12 +0200 Olaf Kirch <[email protected]> wrote:

Every time a non-ethernet device is configured (e.g. when using PPP) the kernel logs a message saying "not allocating divert_blk for non-ethernet device". This patch disables the message.

Are you sure? All our kernels have CONFIG_NET_DIVERT disabled. I don't see how you could get this message unless you enabled it on your own. If you did that just disable it, it's imho an useless option.

Oops, that should have gone to Olaf privately. Sorry for the noise.

-Andi