Skip to contentSkip to conversation

MicroBlaze port of U-Boot

PATCH New Yasushi SHOJI 3 participants 8 messages Apr 6, 2004 – Jun 28, 2004

lore
Share & tools
lore

Yasushi SHOJI

author
#0 lore raw

PATCH 1/1 MicroBlaze port of U-Boot

Hello all,

Here is a patch against the current CVS for microblaze port of u-boot. I does nothing but boot itself, but this can be a start.

Suggestions, thoughts, and comments are welcome, of course.

best regards,
--
yashi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-suzaku.patch.gz
Type: application/octet-stream
Size: 18197 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040407/7f4d8b4e/attachment.obj

#1 lore raw

PATCH 1/1 MicroBlaze port of U-Boot

Am Dienstag, 6. April 2004 21:40 schrieb Yasushi SHOJI:

Quoted 10 lines

Hello all,

Here is a patch against the current CVS for microblaze port of u-boot. I does nothing but boot itself, but this can be a start.

Suggestions, thoughts, and comments are welcome, of course.

best regards,
--
yashi

Looks nice - two hints/annotations:

1.) You should avoid the serial_init() & main_loop() calls inside your board_init() function. I think it's an unclean U-Boot coding style. The right place would be in lib_microblaze/board.c functions board_init_[rf]() or board_init() for targets without Flash/RAM abstraction (like Nios). Why do you do so?

2.) As far as I can remember the Microblaze CPU is the Soft CPU by Xilinx like Nios by Altera. So the core will be very very flexible and have to be configurable. Have a look at the differen Nios targets and let you inspire to map your specific CPU configuration into the U-Boot configuration managment.

Best regards,
Stepha Linz

author
#2 lore raw

PATCH 1/1 MicroBlaze port of U-Boot

Hi Stephan,

At Wed, 7 Apr 2004 09:09:05 +0200,

Quoted 6 lines · Stephan Linz

Am Dienstag, 6. April 2004 21:40 schrieb Yasushi SHOJI:

Quoted 4 lines

Here is a patch against the current CVS for microblaze port of u-boot. I does nothing but boot itself, but this can be a start.

Suggestions, thoughts, and comments are welcome, of course.

[...]

Quoted 7 lines

Looks nice - two hints/annotations:

1.) You should avoid the serial_init() & main_loop() calls inside your board_init() function. I think it's an unclean U-Boot coding style. The right place would be in lib_microblaze/board.c functions board_init_[rf]() or board_init() for targets without Flash/RAM abstraction (like Nios). Why do you do so?

That's my mistake. Thank you for pointing out.

Quoted 4 lines

2.) As far as I can remember the Microblaze CPU is the Soft CPU by Xilinx like Nios by Altera. So the core will be very very flexible and have to be configurable. Have a look at the differen Nios targets and let you inspire to map your specific CPU configuration into the U-Boot configuration managment.

I've had noticed that NIOS support is there but I'm still tring to grasp what is needed and how it works.

I'll dig into the list archive and read some more documents.

# pointers are always welcome ;)

anyway, here is the incremental patch to move board_init() to lib_microblaze/board.c.

best regards,
--
yashi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-suzaku-board_init-fix.patch
Type: application/octet-stream
Size: 1465 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040407/c3534abf/attachment.obj

#3 lore raw

PATCH 1/1 MicroBlaze port of U-Boot

Quoted 3 lines · In message <[email protected]> you wrote:

anyway, here is the incremental patch to move board_init() to lib_microblaze/board.c.

Thanks, appied.

Please don't forget to provide a CHANGELOG entry for your patches.

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Of all possible committee reactions to any  given  agenda  item,  the
reaction  that will occur is the one which will liberate the greatest
amount of hot air.                                -- Thomas L. Martin
#4 lore raw

PATCH 1/1 MicroBlaze port of U-Boot

In reply to Yasushi SHOJI

Dear Yashi,

Quoted 3 lines · in message <[email protected]> you wrote:

Here is a patch against the current CVS for microblaze port of u-boot. I does nothing but boot itself, but this can be a start.

Added, thanks a lot!!

Quoted 1 line

Suggestions, thoughts, and comments are welcome, of course.

I omitted the linux/linkage.h header file as I think this is not necessary - please check, though.

Also, please provide an additional patch to add yourself to the CREDITS and MAINTAINERS files.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
People have one thing in common: they are all different.
author
#5 lore raw

PATCH 1/1 MicroBlaze port of U-Boot

Hi Wolfgang,

# sorry for the very late reply

At Sun, 18 Apr 2004 23:06:20 +0200,

Quoted 8 lines · Wolfgang Denk

Dear Yashi,

Quoted 3 lines · in message <[email protected]> you wrote:

Here is a patch against the current CVS for microblaze port of u-boot. I does nothing but boot itself, but this can be a start.

Quoted 6 lines

Added, thanks a lot!!

Quoted 1 line

Suggestions, thoughts, and comments are welcome, of course.

I omitted the linux/linkage.h header file as I think this is not necessary - please check, though.

yup, you are right.

Quoted 2 lines

Also, please provide an additional patch to add yourself to the CREDITS and MAINTAINERS files.

attached.

At Sun, 18 Apr 2004 23:25:43 +0200,

Quoted 9 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:

anyway, here is the incremental patch to move board_init() to lib_microblaze/board.c.

Thanks, appied.

Please don't forget to provide a CHANGELOG entry for your patches.

attached.

Also I have modified to include MicroBlaze in README. The reason why it's a big change is that the string "lib_microblaze" is too long to fit old indentation. no contents changed.

best regards,
--
yashi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot.patch
Type: application/octet-stream
Size: 6324 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040626/e31f395a/attachment.obj

author
#6 lore raw

PATCH 1/1 MicroBlaze port of U-Boot

Hi Wolfgang,

please dump this whole thing if you haven't applied. I'll resubmit revised patch soon.

thanks,
--
yashi

At Sat, 26 Jun 2004 23:27:42 +0900,

Quoted 50 lines · yashi

Hi Wolfgang,

# sorry for the very late reply

At Sun, 18 Apr 2004 23:06:20 +0200,

Quoted 8 lines · Wolfgang Denk

Dear Yashi,

Quoted 3 lines · in message <[email protected]> you wrote:

Here is a patch against the current CVS for microblaze port of u-boot. I does nothing but boot itself, but this can be a start.

Quoted 6 lines

Added, thanks a lot!!

Quoted 1 line

Suggestions, thoughts, and comments are welcome, of course.

I omitted the linux/linkage.h header file as I think this is not necessary - please check, though.

yup, you are right.

Quoted 2 lines

Also, please provide an additional patch to add yourself to the CREDITS and MAINTAINERS files.

attached.

At Sun, 18 Apr 2004 23:25:43 +0200,

Quoted 9 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:

anyway, here is the incremental patch to move board_init() to lib_microblaze/board.c.

Thanks, appied.

Please don't forget to provide a CHANGELOG entry for your patches.

attached.

Also I have modified to include MicroBlaze in README. The reason why it's a big change is that the string "lib_microblaze" is too long to fit old indentation. no contents changed.

best regards,
--
yashi

#7 lore raw

PATCH 1/1 MicroBlaze port of U-Boot

Quoted 3 lines · In message <[email protected]> you wrote:

please dump this whole thing if you haven't applied. I'll resubmit revised patch soon.

OK, I dropped it.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Anything free is worth what you pay for it.