Skip to contentSkip to conversation

netpoll transmit busy bugfix

PATCH Applied Matt Mackall 2 participants 2 messages Apr 10, 2004 – Apr 13, 2004 Networking

lore
Share & tools
lore

Matt Mackall

author
#0 lore raw

PATCH 1/1 netpoll transmit busy bugfix

Fix for handling of full transmit queue when netpoll trap is enabled.

Quoted 1 line

From Stelian Pop <[email protected]>

%patch

net/core/netpoll.c +3 -9
Index: mm/net/core/netpoll.c
===================================================================
@@ -163,21 +163,15 @@
 	spin_lock(&np->dev->xmit_lock);
 	np->dev->xmit_lock_owner = smp_processor_id();
 
-	if (netif_queue_stopped(np->dev)) {
-		np->dev->xmit_lock_owner = -1;
-		spin_unlock(&np->dev->xmit_lock);
-
-		netpoll_poll(np);
-		goto repeat;
-	}
-
 	status = np->dev->hard_start_xmit(skb, np->dev);
 	np->dev->xmit_lock_owner = -1;
 	spin_unlock(&np->dev->xmit_lock);
 
 	/* transmit busy */
-	if(status)
+	if(status) {
+		netpoll_poll(np);
 		goto repeat;
+	}
 }
 
 void netpoll_send_udp(struct netpoll *np, const char *msg, int len)

%diffstat

 netpoll.c |   12 +++---------
 1 files changed, 3 insertions(+), 9 deletions(-)
Signature · 1 line
Matt Mackall : http://www.selenic.com : Linux development and consulting