udev_dbus changes

From: Kay Sievers <[email protected]>
To: Greg KH <[email protected]>
CC: hotplug <[email protected]>
Subject: [PATCH] udev_dbus changes
Date: Sun, 11 Apr 2004 03:51:07 +0200

Here we change extras/dbus/* to
o install the binary in /etc/dev.d
o append .dev to the binary
o add David's copyright
o add the listener script to watch the sent dbus messages
o removed the undefined udev_log variable
o switch printf() to dbg()

thanks,
Kay

diff -Nru a/extras/dbus/Makefile b/extras/dbus/Makefile

extras/dbus/Makefile +3 -1

@@ -23,7 +23,7 @@
 sbindir =	${exec_prefix}/sbin
 usrbindir =	${exec_prefix}/usr/bin
 mandir =	${prefix}/usr/share/man
-hotplugdir =	${etcdir}/hotplug.d/default
+devddir =	${etcdir}/dev.d/default
 dbusdir =	${etcdir}/dbus-1/system.d
 configdir =	${etcdir}/udev/
 initdir = 	${etcdir}/init.d/

@@ -53,9 +53,11 @@
 install-dbus-policy:
 	$(INSTALL) -d $(DESTDIR)$(dbusdir)
 	$(INSTALL_DATA) etc/dbus-1/system.d/udev_sysbus_policy.conf 
 $(DESTDIR)$(dbusdir)
+	$(INSTALL_PROGRAM) $(PROG) $(DESTDIR)$(devddir)/$(PROG).dev
 
 uninstall-dbus-policy:
 	- rm $(DESTDIR)$(dbusdir)/udev_sysbus_policy.conf
+	- rm $(DESTDIR)$(devddir)/$(PROG).dev
 
 install: install-dbus-policy all

diff -Nru a/extras/dbus/dbus-listener.py b/extras/dbus/dbus-listener.py

extras/dbus/dbus-listener.py new file +25 -0

@@ -0,0 +1,25 @@
+#!/usr/bin/python
+
+import dbus
+import gtk
+
+def udev_signal_received(dbus_iface, member, service, object_path,
+message):
+	[filename, sysfs_path] = message.get_args_list()
+	if member='NodeCreated':
+		print 'Node %s created for %s'%(filename, sysfs_path)
+	elif member='NodeDeleted':
+		print 'Node %s deleted for %s'%(filename, sysfs_path)
+
+def main():
+	bus = dbus.Bus(dbus.Bus.TYPE_SYSTEM)
+	bus.add_signal_receiver(udev_signal_received,
+		'org.kernel.udev.NodeMonitor',		# interface
+		'org.kernel.udev',			# service
+		'/org/kernel/udev/NodeMonitor')		# object
+
+	gtk.mainloop()
+
+if __name__ = '__main__':
+	main()
+

diff -Nru a/extras/dbus/udev_dbus.c b/extras/dbus/udev_dbus.c

extras/dbus/udev_dbus.c +27 -10

@@ -1,3 +1,23 @@
+/*
+ * udev_dbus.c
+ *
+ * Copyright (C) 2003 David Zeuthen <[email protected]>
+ *
+ *	This program is free software; you can redistribute it and/or modify it
+ *	under the terms of the GNU General Public License as published by the
+ *	Free Software Foundation version 2 of the License.
+ *
+ *	This program is distributed in the hope that it will be useful, but
+ *	WITHOUT ANY WARRANTY; without even the implied warranty of
+ *	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *	General Public License for more details.
+ *
+ *	You should have received a copy of the GNU General Public License along
+ *	with this program; if not, write to the Free Software Foundation, Inc.,
+ *	675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ */
+
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>

@@ -18,21 +38,18 @@
 {
 	va_list args;
 
-	if (!udev_log)
-		return;
-
 	va_start(args, format);
 	vsyslog(level, format, args);
 	va_end(args);
 }
 #endif
 
-/** variable for the connection the to system message bus or #NULL
+/*  variable for the connection the to system message bus or NULL
  *  if we cannot connect or acquire the org.kernel.udev service
  */
 static DBusConnection* sysbus_connection;
 
-/** Disconnect from the system message bus */
+/* disconnect from the system message bus */
 static void sysbus_disconnect(void)
 {
 	if (sysbus_connection = NULL)

@@ -42,12 +59,12 @@
 	sysbus_connection = NULL;
 }
 
-/** Connect to the system message bus */
+/* connect to the system message bus */
 static void sysbus_connect(void)
 {
 	DBusError error;
 
-	/* Connect to a well-known bus instance, the system bus */
+	/* connect to a well-known bus instance, the system bus */
 	dbus_error_init(&error);
 	sysbus_connection = dbus_bus_get(DBUS_BUS_SYSTEM, &error);
 	if (sysbus_connection = NULL) {

@@ -70,15 +87,15 @@
 	dbus_bus_acquire_service(sysbus_connection, "org.kernel.udev", 0,
 				 &error);
 	if (dbus_error_is_set(&error)) {
-		printf("cannot acquire org.kernel.udev service, error %s: %s'",
-		       error.name, error.message);
+		dbg("cannot acquire org.kernel.udev service, error %s: %s'",
+		    error.name, error.message);
 		sysbus_disconnect();
 		return;
 	}
 }
 
 
-/** Send out a signal that a device node is created
+/*  send out a signal that a device node is created
  *
  *  @param  devname             name of the device node, e.g. /dev/sda1
  *  @param  path                Sysfs path of device

o install the binary in /etc/dev.d

Quoted 1 line · Kay Sievers

o install the binary in /etc/dev.d

Bad idea. They should be installed in /sbin/ and referenced by a symlink.

Quoted 2 lines

Quoted 1 line

o install the binary in /etc/dev.d

Bad idea. They should be installed in /sbin/ and referenced by a symlink.

Ok, sounds better. But should it go in /sbin/ or /usr/sbin/. Hal installs the caller in /usr/libexec/, so what's the best :)

Here we change extras/dbus/* to
o install the binary in /etc/dev.d
o append .dev to the binary
o add David's copyright
o add the listener script to watch the sent dbus messages
o removed the undefined udev_log variable
o switch printf() to dbg()

Quoted 4 lines · Kay Sievers

Quoted 2 lines

Quoted 1 line

o install the binary in /etc/dev.d

Bad idea. They should be installed in /sbin/ and referenced by a symlink.

Ok, sounds better. But should it go in /sbin/ or /usr/sbin/. Hal installs the caller in /usr/libexec/, so what's the best :)

/usr/libexec has been removed from FHS many years ago.
For debian, I use /usr/sbin/ for the programs which depends on libraries in /usr/lib/ (currently only udev_dbus) and /sbin/ for the others.

Hmm, so FHS doesn't specify a directory for binaries, which are not included in the $PATH by default, right?

Quoted 7 lines · Kay Sievers

Here we change extras/dbus/* to
o install the binary in /etc/dev.d
o append .dev to the binary
o add David's copyright
o add the listener script to watch the sent dbus messages
o removed the undefined udev_log variable
o switch printf() to dbg()

Here we install the binary in /usr/sbin/ and symlink it to /etc/dev.d/ with the .dev suffix.