bug? fpswa_interface needs to be exported
Hi,
In 2.6.4/5, efivars can be built as a module, but it depends on 'fpswa_interface' which is not exported by fpswa.c. I think you need a EXPORT_SYMBOL for that variable.
Debian's 2.6.4-mckinley-smp kernel has this built as a module but it cannot be loaded:
efivars: Unknown symbol fpswa_interface
Cheers,
Signature · 1 line
Martin
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Martin Pool
Martin> Hi, In 2.6.4/5, efivars can be built as a module, but it Martin> depends on 'fpswa_interface' which is not exported by Martin> fpswa.c. I think you need a EXPORT_SYMBOL for that Martin> variable.
Martin> Debian's 2.6.4-mckinley-smp kernel has this built as a Martin> module but it cannot be loaded:
Martin> efivars: Unknown symbol fpswa_interface
Want to send a (tested) patch?
--david
Quoted 7 lines · David Mosberger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Martin Pool
Martin> Hi, In 2.6.4/5, efivars can be built as a module, but it Martin> depends on '
fpswa_interface' which is not exported by Martin>fpswa.c. I think you need aEXPORT_SYMBOLfor that Martin> variable.
Quoted 6 lines
Martin> Debian's 2.6.4-mckinley-smp kernel has this built as a Martin> module but it cannot be loaded:
Martin> efivars: Unknown symbol
fpswa_interfaceWant to send a (tested) patch?
This will fix it:
arch/ia64/kernel/traps.c +2 -0
@@ -13,6 +13,7 @@#include <linux/sched.h> #include <linux/tty.h> #include <linux/vt_kern.h> /* For unblank_screen() */ +#include <linux/module.h> /* for EXPORT_SYMBOL */ #include <asm/fpswa.h> #include <asm/hardirq.h>
@@ -47,6 +48,7 @@extern spinlock_t timerlist_lock;fpswa_interface_t *fpswa_interface; +EXPORT_SYMBOL (fpswa_interface);void __init trap_init (void )
There was also a bug in modpost that suppressed the warning that should have come out at compile time. Rusty has fixed it in Linus's tree.
Signature · 1 line
Martin