Skip to contentSkip to conversation

Yet another ppc64 hugepage cleanup

PATCH David Gibson 1 participant 1 message Apr 16, 2004

lore
Share & tools
lore
#0 lore raw

Andrew, please apply.

Trivial cleanup to flush_hash_hugepage() in the ppc64 hugepage code.

arch/ppc64/mm/hugetlbpage.c +2 -3
Index: working-2.6/arch/ppc64/mm/hugetlbpage.c
===================================================================
@@ -736,7 +736,7 @@
 static void flush_hash_hugepage(mm_context_t context, unsigned long ea,
 				hugepte_t pte, int local)
 {
-	unsigned long vsid, vpn, va, hash, secondary, slot;
+	unsigned long vsid, vpn, va, hash, slot;
 
 	BUG_ON(hugepte_bad(pte));
 	BUG_ON(!in_hugepage_area(context, ea));
@@ -746,8 +746,7 @@
 	va = (vsid << 28) | (ea & 0x0fffffff);
 	vpn = va >> LARGE_PAGE_SHIFT;
 	hash = hpt_hash(vpn, 1);
-	secondary = !!(hugepte_val(pte) & _HUGEPAGE_SECONDARY);
-	if (secondary)
+	if (hugepte_val(pte) & _HUGEPAGE_SECONDARY)
 		hash = ~hash;
 	slot = (hash & htab_data.htab_hash_mask) * HPTES_PER_GROUP;
 	slot += (hugepte_val(pte) & _HUGEPAGE_GROUP_IX) >> 5;
Signature · 4 lines
David Gibson			| For every complex problem there is a
david AT gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.
http://www.ozlabs.org/people/dgibson