Skip to contentSkip to conversation

fixes warning of missing initializers for *.poll_revents

PATCH In review Martin Langer 2 participants 2 messages Apr 19, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fixes warning of missing initializers for *.poll_revents

This bunch of patches fixes compiler warnings like these one:
pcm_multi.c:646: warning: missing initializer
pcm_multi.c:646: warning: (near initialization for snd_pcm_multi_ops.poll_revpcm_shm.c:589: warning: missing initializer for snd_pcm_multi_ops.poll_revents')

But perhaps more interesting values than NULL are prefered.... Please review before applying it.

martin

Index: alsa-lib/src/pcm/pcm_hooks.c
===================================================================
RCS file: /cvsroot/alsa/alsa-lib/src/pcm/pcm_hooks.c,v retrieving revision 1.32

src/pcm/pcm_hooks.c +1 -0
diff -u -r1.32 pcm_hooks.c
@@ -305,6 +305,7 @@
 	.dump = snd_pcm_hooks_dump,
 	.nonblock = snd_pcm_hooks_nonblock,
 	.async = snd_pcm_hooks_async,
+	.poll_revents = NULL,
 	.mmap = snd_pcm_hooks_mmap,
 	.munmap = snd_pcm_hooks_munmap,
 };

Index: alsa-lib/src/pcm/pcm_meter.c
===================================================================
RCS file: /cvsroot/alsa/alsa-lib/src/pcm/pcm_meter.c,v retrieving revision 1.44

src/pcm/pcm_meter.c +1 -0
diff -u -r1.44 pcm_meter.c
@@ -609,6 +609,7 @@
 	.dump = snd_pcm_meter_dump,
 	.nonblock = snd_pcm_meter_nonblock,
 	.async = snd_pcm_meter_async,
+	.poll_revents = NULL,
 	.mmap = snd_pcm_meter_mmap,
 	.munmap = snd_pcm_meter_munmap,
 };

Index: alsa-lib/src/pcm/pcm_multi.c
===================================================================
RCS file: /cvsroot/alsa/alsa-lib/src/pcm/pcm_multi.c,v retrieving revision 1.87

src/pcm/pcm_multi.c +1 -0
diff -u -r1.87 pcm_multi.c
@@ -641,6 +641,7 @@
 	.dump = snd_pcm_multi_dump,
 	.nonblock = snd_pcm_multi_nonblock,
 	.async = snd_pcm_multi_async,
+	.poll_revents = NULL,
 	.mmap = snd_pcm_multi_mmap,
 	.munmap = snd_pcm_multi_munmap,
 };

Index: alsa-lib/src/pcm/pcm_null.c
===================================================================
RCS file: /cvsroot/alsa/alsa-lib/src/pcm/pcm_null.c,v retrieving revision 1.50

src/pcm/pcm_null.c +1 -0
diff -u -r1.50 pcm_null.c
@@ -324,6 +324,7 @@
 	.dump = snd_pcm_null_dump,
 	.nonblock = snd_pcm_null_nonblock,
 	.async = snd_pcm_null_async,
+	.poll_revents = NULL,
 	.mmap = snd_pcm_null_mmap,
 	.munmap = snd_pcm_null_munmap,
 };

Index: alsa-lib/src/pcm/pcm_share.c
===================================================================
RCS file: /cvsroot/alsa/alsa-lib/src/pcm/pcm_share.c,v retrieving revision 1.79

src/pcm/pcm_share.c +1 -0
diff -u -r1.79 pcm_share.c
@@ -1274,6 +1274,7 @@
 	.dump = snd_pcm_share_dump,
 	.nonblock = snd_pcm_share_nonblock,
 	.async = snd_pcm_share_async,
+	.poll_revents = NULL,
 	.mmap = snd_pcm_share_mmap,
 	.munmap = snd_pcm_share_munmap,
 };

Index: alsa-lib/src/pcm/pcm_shm.c
===================================================================
RCS file: /cvsroot/alsa/alsa-lib/src/pcm/pcm_shm.c,v retrieving revision 1.60

src/pcm/pcm_shm.c +1 -0
diff -u -r1.60 pcm_shm.c
@@ -584,6 +584,7 @@
 	.dump = snd_pcm_shm_dump,
 	.nonblock = snd_pcm_shm_nonblock,
 	.async = snd_pcm_shm_async,
+	.poll_revents = NULL,
 	.mmap = snd_pcm_shm_mmap,
 	.munmap = snd_pcm_shm_munmap,
 };
Signature · 9 lines
                                     Living on earth may be expensive,
                   but it includes an annual free trip around the sun. 


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
#1 lore raw
Quoted 8 lines · Martin Langer

This bunch of patches fixes compiler warnings like these one:
pcm_multi.c:646: warning: missing initializer
pcm_multi.c:646: warning: (near initialization for snd_pcm_multi_ops.poll_revpcm_shm.c:589: warning: missing initializer for snd_pcm_multi_ops.poll_revents')

But perhaps more interesting values than NULL are prefered.... Please review before applying it.

gcc 2.95.4 and 3.0.4ive this warning, but 3.2.3 and 3.3.3 do not (with -Wall -W, at least). I think a large point of using this C99 syntax is to only initialize what you want, and not clutter the code with lots of redundant NULL initialization.

Signature · 8 lines
Glenn Maynard


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click