Skip to contentSkip to conversation

why change_page_attr on x86 uses __flush_tlb_all

DISCUSSION Andi Kleen 2 participants 2 messages Apr 15, 2004 – Apr 22, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw
Quoted 3 lines · Nagendra Singh Tomar

I would expect __flush_tlb_one (for each page) as a better choice.
It'll be nice if someone can hoghlight on why __flush_tlb_all is used. The kernel version I am referring from is 2.4.18-14

This works around a bug in some early Athlons with flushing global large pages. Also it makes the code slightly simpler and change_page_attr is not really performance critical.

-Andi

#2 lore raw

Hi!

Quoted 7 lines
Quoted 3 lines

I would expect __flush_tlb_one (for each page) as a better choice.
It'll be nice if someone can hoghlight on why __flush_tlb_all is used. The kernel version I am referring from is 2.4.18-14

This works around a bug in some early Athlons with flushing global large pages. Also it makes the code slightly simpler and change_page_attr is not really performance critical.

Perhaps comment should be added? Otherwise someone is going to "fix" it sooner or later.

Signature · 1 line
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms