Skip to contentSkip to conversation

Kconfig.debug family

PATCH In review Randy.Dunlap 5 participants 11 messages Apr 22, 2004 – Apr 29, 2004 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kconfig.debug family

Localizes kernel debug options in lib/Kconfig.debug. Puts arch-specific debug options in $ARCH/Kconfig.debug.

updated for 2.6.6-rc2

http://developer.osdl.org/rddunlap/patches/kconf_debug_1file_266rc2.patch

Also included here as a gzipped attachment.

 arch/alpha/Kconfig           |  104 ---------------------
 arch/alpha/Kconfig.debug     |   54 +++++++++++
 arch/arm/Kconfig             |  160 --------------------------------
 arch/arm/Kconfig.debug       |  113 +++++++++++++++++++++++
 arch/arm26/Kconfig           |  113 -----------------------
 arch/arm26/Kconfig.debug     |   58 +++++++++++
 arch/cris/Kconfig            |   14 --
 arch/cris/Kconfig.debug      |   14 ++
 arch/h8300/Kconfig           |   72 --------------
 arch/h8300/Kconfig.debug     |   66 +++++++++++++
 arch/i386/Kconfig            |  125 -------------------------
 arch/i386/Kconfig.debug      |   14 ++
 arch/ia64/Kconfig            |  114 -----------------------
 arch/ia64/Kconfig.debug      |   62 ++++++++++++
 arch/m68k/Kconfig            |   38 -------
 arch/m68k/Kconfig.debug      |    8 +
 arch/m68knommu/Kconfig       |   55 -----------
 arch/m68knommu/Kconfig.debug |   41 ++++++++
 arch/mips/Kconfig            |  119 ------------------------
 arch/mips/Kconfig.debug      |   66 +++++++++++++
 arch/parisc/Kconfig          |   49 ---------
 arch/parisc/Kconfig.debug    |    5 +
 arch/ppc/Kconfig             |  124 -------------------------
 arch/ppc/Kconfig.debug       |   71 ++++++++++++++
 arch/ppc64/Kconfig           |   80 ----------------
 arch/ppc64/Kconfig.debug     |   26 +++++
 arch/s390/Kconfig            |   56 -----------
 arch/s390/Kconfig.debug      |    6 +
 arch/sh/Kconfig              |  140 ----------------------------
 arch/sh/Kconfig.debug        |  110 ++++++++++++++++++++++
 arch/sparc/Kconfig           |   72 --------------
 arch/sparc/Kconfig.debug     |   13 ++
 arch/sparc64/Kconfig         |  104 ---------------------
 arch/sparc64/Kconfig.debug   |   37 +++++++
 arch/um/Kconfig              |   60 ------------
 arch/um/Kconfig.debug        |   34 ++++++
 arch/v850/Kconfig            |   29 -----
 arch/v850/Kconfig.debug      |    9 +
 arch/x86_64/Kconfig          |  101 --------------------
 arch/x86_64/Kconfig.debug    |   46 +++++++++
 init/Kconfig                 |    8 -
 lib/Kconfig.debug            |  211 +++++++++++++++++++++++++++++++++++++++++++
 42 files changed, 1084 insertions(+), 1717 deletions(-)

Like it, kill/drop it, fix (what?) problems, ... ?

--
~Randy

#1 lore raw
Quoted 5 lines · Randy.Dunlap
 lib/Kconfig.debug            |  211 +++++++++++++++++++++++++++++++++++++++++++
 42 files changed, 1084 insertions(+), 1717 deletions(-)

Like it, kill/drop it, fix (what?) problems, ... ?

Looks good to me, can we convince a certain someone? ;)

#2 lore raw
In reply to Randy.Dunlap
Quoted 8 lines · Randy.Dunlap

Localizes kernel debug options in lib/Kconfig.debug.
Puts arch-specific debug options in $ARCH/Kconfig.debug.

updated for 2.6.6-rc2

http://developer.osdl.org/rddunlap/patches/kconf_debug_1file_266rc2.patch

Quoted 7 lines

Also included here as a gzipped attachment.

...

  42 files changed, 1084 insertions(+), 1717 deletions(-)

Like it, kill/drop it, fix (what?) problems, ... ?

It breaks at least six patches from -mm and I'm too lazy to do anything about it.

Please resend after 2.6.6.

#3 lore raw
In reply to Randy.Dunlap
Quoted 2 lines · Randy.Dunlap

Localizes kernel debug options in lib/Kconfig.debug. Puts arch-specific debug options in $ARCH/Kconfig.debug.

[snip]

Quoted 2 lines
 arch/ppc/Kconfig             |  124 -------------------------
 arch/ppc/Kconfig.debug       |   71 ++++++++++++++

OCP shouldn't be moved into Kconfig.debug, it's just in an odd location right now.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#4 lore raw

On Mon, 26 Apr 2004 09:42:52 -0700 Tom Rini wrote:

| On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:
| 
| > Localizes kernel debug options in lib/Kconfig.debug.
| > Puts arch-specific debug options in $ARCH/Kconfig.debug.
| [snip]
| >  arch/ppc/Kconfig             |  124 -------------------------
| >  arch/ppc/Kconfig.debug       |   71 ++++++++++++++
| 
| OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
| right now.

Thanks. I moved it to under Processor options, before Platform options. Is that OK?

Updated patch is here:
http://developer.osdl.org/rddunlap/patches/kdebug1file_266rc2_v2.patch
(applies to 2.6.6-rc3 with a few offsets)

Waiting for 2.6.6-final...

--
~Randy
(Again. Sometimes I think ln -s /usr/src/linux/.config .signature) -- akpm

#5 lore raw
Quoted 14 lines · Randy.Dunlap

On Mon, 26 Apr 2004 09:42:52 -0700 Tom Rini wrote:

| On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:
| 
| > Localizes kernel debug options in lib/Kconfig.debug.
| > Puts arch-specific debug options in $ARCH/Kconfig.debug.
| [snip]
| >  arch/ppc/Kconfig             |  124 -------------------------
| >  arch/ppc/Kconfig.debug       |   71 ++++++++++++++
| 
| OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
| right now.
Quoted 2 lines

Thanks. I moved it to under Processor options, before Platform options. Is that OK?

Yup, thanks.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#6 lore raw
In reply to Randy.Dunlap
Quoted 13 lines · Randy.Dunlap

On Mon, 26 Apr 2004 09:42:52 -0700 Tom Rini wrote:

| On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:
| > Localizes kernel debug options in lib/Kconfig.debug.
| > Puts arch-specific debug options in $ARCH/Kconfig.debug.
|
| [snip]
|
| >  arch/ppc/Kconfig             |  124 -------------------------
| >  arch/ppc/Kconfig.debug       |   71 ++++++++++++++
|
| OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
| right now.
Quoted 8 lines

Thanks. I moved it to under Processor options, before Platform options. Is that OK?

Updated patch is here:
http://developer.osdl.org/rddunlap/patches/kdebug1file_266rc2_v2.patch
(applies to 2.6.6-rc3 with a few offsets)

Waiting for 2.6.6-final...

I guess it is not a final patch?

Only on x86 it does a proper thing:

arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug

Cheers,
Bartlomiej

#7 lore raw

On Thu, 29 Apr 2004 18:42:23 +0200 Bartlomiej Zolnierkiewicz wrote:

| On Thursday 29 of April 2004 17:38, Randy.Dunlap wrote:
| > On Mon, 26 Apr 2004 09:42:52 -0700 Tom Rini wrote:
| > | On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:
| > | > Localizes kernel debug options in lib/Kconfig.debug.
| > | > Puts arch-specific debug options in $ARCH/Kconfig.debug.
| > |
| > | [snip]
| > |
| > | >  arch/ppc/Kconfig             |  124 -------------------------
| > | >  arch/ppc/Kconfig.debug       |   71 ++++++++++++++
| > |
| > | OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
| > | right now.
| >
| > Thanks.  I moved it to under Processor options, before Platform
| > options.  Is that OK?
| >
| > Updated patch is here:
| >   http://developer.osdl.org/rddunlap/patches/kdebug1file_266rc2_v2.patch
| > (applies to 2.6.6-rc3 with a few offsets)
| >
| > Waiting for 2.6.6-final...
| 
| I guess it is not a final patch?

Well, it hasn't been accepted.

| Only on x86 it does a proper thing:
| 
| arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug

That's because I goofed up... it's the wrong patch.

I was trying something that someone suggested (You!) and it didn't work out in a desirable way as far as how it's presented in {x,menu}config, so I need to fix that (i386 part) and then you can complain some more. :)

--
~Randy

#8 lore raw
Quoted 9 lines · Randy.Dunlap

On Thu, 29 Apr 2004 18:42:23 +0200 Bartlomiej Zolnierkiewicz wrote:

| Only on x86 it does a proper thing:
|
| arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug

That's because I goofed up... it's the wrong patch.

I was trying something that someone suggested (You!) and it didn't

:)

Quoted 2 lines

work out in a desirable way as far as how it's presented in {x,menu}config, so I need to fix that (i386 part) and then you

In your previous patch (vs 2.6.5) there was only one "Kernel hacking" menu, in this one there are two menus: "Kernel hacking" and "X86 kernel hacking".

I hacked it quickly and I have one menu again (on x86 arch specific options are not configurable) so I also hacked+checked ppc and 'make menuconfig' looks OK). Did I miss something?

arch/i386/Kconfig.debug +3 -2
diff -u linux-2.6.6-rc2-bk4-bzolnier/arch/i386/Kconfig.debug linux-2.6.6-rc2-bk4-bzolnier/arch/i386/Kconfig.debug
@@ -1,6 +1,7 @@
-source "lib/Kconfig.debug"
 
-menu "X86 kernel hacking"
+menu "Kernel hacking"
+
+source "lib/Kconfig.debug"
 
 config X86_FIND_SMP_CONFIG
 	bool
arch/ppc/Kconfig +1 -1
diff -u linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig
@@ -1108,7 +1108,7 @@
 
 source "lib/Kconfig"
 
-source "lib/Kconfig.debug"
+source "arch/ppc/Kconfig.debug"
 
 source "security/Kconfig"
 
arch/ppc/Kconfig.debug +3 -2
diff -u linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig.debug linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig.debug
@@ -1,4 +1,6 @@
-menu "PPC kernel hacking"
+menu "Kernel hacking"
+
+source "lib/Kconfig.debug"
 
 config KGDB
 	bool "Include kgdb kernel debugger"
@@ -66 +67,0 @@
-
lib/Kconfig.debug +2 -7
diff -u linux-2.6.6-rc2-bk4-bzolnier/lib/Kconfig.debug linux-2.6.6-rc2-bk4-bzolnier/lib/Kconfig.debug
@@ -1,6 +1,4 @@
-# Generic debug menu
-
-menu "Kernel hacking"
+# Generic debug options
 
 config DEBUG_KERNEL
 	bool "Kernel debugging"
@@ -97,7 +95,7 @@
 	  debugging info resulting in a larger kernel image.
 	  Say Y here only if you plan to use gdb to debug the kernel.
 	  If you don't debug the kernel, you can say N.
-	  
+
 config FRAME_POINTER
 	bool "Compile the kernel with frame pointers"
 	depends on DEBUG_KERNEL && (!ARM && !ARM26 && !X86_64 && !S390 && !V850 && !SPARC64)
@@ -148,3 +145,0 @@
-
-endmenu
-
Quoted 1 line

can complain some more. :)

:)

Bartlomiej

#9 lore raw

On Thu, 29 Apr 2004 20:54:49 +0200 Bartlomiej Zolnierkiewicz wrote:

| On Thursday 29 of April 2004 18:51, Randy.Dunlap wrote:
| > On Thu, 29 Apr 2004 18:42:23 +0200 Bartlomiej Zolnierkiewicz wrote:
| 
| > | Only on x86 it does a proper thing:
| > |
| > | arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug
| >
| > That's because I goofed up... it's the wrong patch.
| >
| > I was trying something that someone suggested (You!) and it didn't
| 
| :)
| 
| > work out in a desirable way as far as how it's presented in
| > {x,menu}config, so I need to fix that (i386 part) and then you
| 
| In your previous patch (vs 2.6.5) there was only one "Kernel hacking" menu,
| in this one there are two menus: "Kernel hacking" and "X86 kernel hacking".
| 
| I hacked it quickly and I have one menu again (on x86 arch specific options
| are not configurable) so I also hacked+checked  ppc and 'make menuconfig'
| looks OK).  Did I miss something?

Hm, looks good to me at first testing, I'll do the other arches.

Thanks much.

--
~Randy

#10 lore raw

Re: [PATCH] Kconfig.debug family (v3-bart)

In reply to Bartlomiej Zolnierkiewicz

On Thu, 29 Apr 2004 20:54:49 +0200 Bartlomiej Zolnierkiewicz wrote:

| On Thursday 29 of April 2004 18:51, Randy.Dunlap wrote:
| > On Thu, 29 Apr 2004 18:42:23 +0200 Bartlomiej Zolnierkiewicz wrote:
| 
| > | Only on x86 it does a proper thing:
| > |
| > | arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug
| >
| > That's because I goofed up... it's the wrong patch.
| >
| > I was trying something that someone suggested (You!) and it didn't
| 
| :)
| 
| > work out in a desirable way as far as how it's presented in
| > {x,menu}config, so I need to fix that (i386 part) and then you
| 
| In your previous patch (vs 2.6.5) there was only one "Kernel hacking" menu,
| in this one there are two menus: "Kernel hacking" and "X86 kernel hacking".
| 
| I hacked it quickly and I have one menu again (on x86 arch specific options
| are not configurable) so I also hacked+checked  ppc and 'make menuconfig'
| looks OK).  Did I miss something?

Bart's changes still look good. I've updated the entire patch to use that model. It's available here:
http://developer.osdl.org/rddunlap/patches/kdebug1menu_266rc2_v3.patch

Any more comments before 2.6.6?

Thanks,
--
~Randy