Skip to contentSkip to conversation

update Documentation/SubmittingPatches to

PATCH In review maximilian attems 2 participants 5 messages Apr 26, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 update Documentation/SubmittingPatches to

Quoted 9 lines · Coywolf Qi Hunt
Quoted 7 lines

arch/i386/boot/setup.S

Quoted 4 lines

========================================================================

arch/i386/boot/setup.S renamed from arch/i386/boot/setup.S.orig +0 -0

you didn't read the faq ;)

I was misled by Documentation/SubmittingPatches.
Patch: remove the bootsect_helper code and a comment fix also.

update Documentation/SubmittingPatches to current patch level, change references from 2.4 to 2.6 and more important suggest the users home dir for his patching and source building (fhs compliance).
change tar.gz in bz2 use.

please speak up if you prefer variable names MYTREE versus SRCTREE, tried to be consistent in choice.

a++ maks

Documentation/SubmittingPatches +12 -9
@@ -35,25 +35,28 @@ not in any lower subdirectory.
 
 To create a patch for a single file, it is often sufficient to do:
 
-	SRCTREE= /devel/linux-2.4
+	SRCTREE= ~/src/linux-2.6.x
+	MYTREE=  ~/src/linux-2.6.x-foo
 	MYFILE=  drivers/net/mydriver.c
 
-	cd $SRCTREE
-	cp $MYFILE $MYFILE.orig
+	cd ~/src
+	cp -a $SRCTREE $MYTREE
+	cd $MYTREE
 	vi $MYFILE	# make your change
-	diff -up $MYFILE.orig $MYFILE > /tmp/patch
+	cd ..
+	diff -up $SRCTREE/$MYFILE $MYTREE/$MYFILE > /tmp/patch
 
 To create a patch for multiple files, you should unpack a "vanilla",
 or unmodified kernel source tree, and generate a diff against your
 own source tree.  For example:
 
-	MYSRC= /devel/linux-2.4
+	MYTREE= ~/src/linux-2.6.x-foo
 
-	tar xvfz linux-2.4.0-test11.tar.gz
-	mv linux linux-vanilla
+	cd ~/src
+	tar xvfj linux-2.6.6.bz2
+	mv linux-2.6.6 linux-vanilla
 	wget http://www.moses.uklinux.net/patches/dontdiff
-	diff -uprN -X dontdiff linux-vanilla $MYSRC > /tmp/patch
-	rm -f dontdiff
+	diff -uprN -X dontdiff linux-vanilla $MYTREE > /tmp/patch
 
 "dontdiff" is a list of files which are generated by the kernel during
 the build process, and should be ignored in any diff(1)-generated

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Re: [Kernel-janitors] [PATCH] update Documentation/SubmittingPatches

Quoted 13 lines · maximilian attems
Quoted 9 lines · Coywolf Qi Hunt
Quoted 7 lines

arch/i386/boot/setup.S

Quoted 4 lines

========================================================================

arch/i386/boot/setup.S renamed from arch/i386/boot/setup.S.orig +0 -0

you didn't read the faq ;)

I was misled by Documentation/SubmittingPatches.
Patch: remove the bootsect_helper code and a comment fix also.

Quoted 8 lines

update Documentation/SubmittingPatches to current patch level, change references from 2.4 to 2.6 and more important suggest the users home dir for his patching and source building (fhs compliance).
change tar.gz in bz2 use.

please speak up if you prefer variable names MYTREE versus SRCTREE, tried to be consistent in choice.

I sent something of the sort recently to LKML for the same reason ;)

http://www.uwsg.iu.edu/hypermail/linux/kernel/0404.3/0033.html

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw

Re: [Kernel-janitors] [PATCH] update Documentation/SubmittingPatches

In reply to maximilian attems
Quoted 3 lines · Zwane Mwaikambo

I sent something of the sort recently to LKML for the same reason ;)

http://www.uwsg.iu.edu/hypermail/linux/kernel/0404.3/0033.html

better pointers,
cool .. minimal changes .. nice patch :)
leaves 2.4 .. can do one on top of yours?

regards maks

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#3 lore raw

Re: [Kernel-janitors] [PATCH] update Documentation/SubmittingPatches

In reply to maximilian attems
Quoted 9 lines · maks attems
Quoted 3 lines · Zwane Mwaikambo

I sent something of the sort recently to LKML for the same reason ;)

http://www.uwsg.iu.edu/hypermail/linux/kernel/0404.3/0033.html

better pointers,
cool .. minimal changes .. nice patch :)
leaves 2.4 .. can do one on top of yours?

I left it at 2.4 since it was just an example, but if Andrew hasn't picked it up then yeah, i wouldn't mind one of top of it.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#4 lore raw

Re: [Kernel-janitors] [PATCH] update Documentation/SubmittingPatches

In reply to maximilian attems
Quoted 2 lines · Zwane Mwaikambo

I left it at 2.4 since it was just an example, but if Andrew hasn't picked it up then yeah, i wouldn't mind one of top of it.

ok you are right of course!
woow quick :)
-- snipp from 2.6.6-rc2-mm2 announce
+submittingpatches-diffing-update.patch

Fix wording in SubmittingPatches
--

a++ maks

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors