Skip to contentSkip to conversation

take3: Updated CPU Hotplug patches for IA64 (pj blessed) Patch [1/7]

PATCH Ashok Raj 2 participants 2 messages May 4, 2004

lore
Share & tools
lore

Ashok Raj

author
#0 lore raw

Hi Andrew/David

Here are the next set of patches for supporting CPU hotplug. This is officially Paul Jackson ([email protected]) blessed for cpumask related issues the earlier patch introduced. Hopefully ready for David-MT to wave the magic wand (blessing) for inclusion in ia64 tree :-)

Thanks to akpm for providing a test base for comments and improve the overall acceptability of the patch.

Due to the changes, i had to change the series (patch order) so i had generic changes or bug fixes before hotplug ia64.

The real changes in this patch set are really changes to cpu_present.patch.
- Removed ARCH_HAS_CPU_PRESENT_MAP
- No confusing ifdef's around for aliasing with/without hotplug for cpu_present and cpu_possible_map
- cpu_present_map is now declared for all architectures, and managed transparently for arch's that dont populate those to work seamlessly.
- Tested for hotlug on tiger4 (logical, not physical remove using echo 0 to the cpu control file in /sys/devices/system/cpu/cpu#/online).
- pj tested boot on SN2. (thanks for testing and a fix for booting, integrated in this patch)

Name: core_kernel_init.patch
Author: Ashok Raj (Intel Corporation)
D: This patch changes __init to __devinit to init_idle so that when a new cpu
D: arrives, it can call these functions at a later time.

---

 linux-2.6.5-lhcs-root/init/main.c    |    2 +-
 linux-2.6.5-lhcs-root/kernel/sched.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched.c renamed from kernel/sched.c~core_kernel_init +1 -1
diff -puN kernel/sched.c~core_kernel_init kernel/sched.c
@@ -2657,7 +2657,7 @@ void show_state(void)
 	read_unlock(&tasklist_lock);
 }
 
-void __init init_idle(task_t *idle, int cpu)
+void __devinit init_idle(task_t *idle, int cpu)
 {
 	runqueue_t *idle_rq = cpu_rq(cpu), *rq = cpu_rq(task_cpu(idle));
 	unsigned long flags;
init/main.c renamed from init/main.c~core_kernel_init +1 -1
diff -puN init/main.c~core_kernel_init init/main.c
@@ -181,7 +181,7 @@ EXPORT_SYMBOL(loops_per_jiffy);
    better than 1% */
 #define LPS_PREC 8
 
-void __init calibrate_delay(void)
+void __devinit calibrate_delay(void)
 {
 	unsigned long ticks, loopbit;
 	int lps_precision = LPS_PREC;

_

#1 lore raw
Quoted 1 line · Ashok

The real changes in this patch set are really changes to cpu_present.patch.

Thank-you, Ashok, for these improvements.

Signature · 3 lines
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <[email protected]> 1.650.933.1373