PCI devices with no PCI_CACHE_LINE_SIZE implemented
Martin, below is a patch to lower the severity of this printk to KERN_DEBUG, as there are devices which (properly) don't implement the PCI_CACHE_LINE_SIZE register, and it's not a bug, so don't print at a WARNING level.
Thanks,
Matt
----- Forwarded message from Matt Domsch <[email protected]> -----
Date: Wed, 5 May 2004 17:50:53 -0500
From: Matt Domsch <[email protected]>
To: Greg KH <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: PCI devices with no PCI_CACHE_LINE_SIZE implemented
In-Reply-To: <[email protected]>
Quoted 6 lines · Greg KH
Quoted 2 lines · Matt Domsch
a) need this be a warning, wouldn't
KERN_DEBUGsuffice, if a message is needed at all? This is printed inpci_generic_prep_mwi().Yes, we should make that
KERN_DEBUG. I don't have a problem with that. Care to make a patch?
Patch for 2.4.27-pre1 appended.
Thanks,
Matt
Signature · 17 lines
Matt Domsch Sr. Software Engineer, Lead Engineer Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com ===== drivers/pci/pci.c 1.47 vs edited ===== --- 1.47/drivers/pci/pci.c Mon Sep 22 07:27:35 2003 +++ edited/drivers/pci/pci.c Wed May 5 17:49:13 2004 @@ -943,7 +943,7 @@ if (cacheline_size == pci_cache_line_size) return 0; - printk(KERN_WARNING "PCI: cache line size of %d is not supported " + printk(KERN_DEBUG "PCI: cache line size of %d is not supported " "by device %s\n", pci_cache_line_size << 2, dev->slot_name); return -EINVAL;
Quoted 7 lines · Matt Domsch
Martin, below is a patch to lower the severity of this printk to
KERN_DEBUG, as there are devices which (properly) don't implement thePCI_CACHE_LINE_SIZEregister, and it's not a bug, so don't print at a WARNING level.Thanks,
Matt
I'd send it straight to Marcelo, saying that the 2.6 PCI maintainer approved it.... Martin hasn't hacked on kernel code in a while...
Jeff
Hi!
Quoted 2 lines
I'd send it straight to Marcelo, saying that the 2.6 PCI maintainer approved it.... Martin hasn't hacked on kernel code in a while...
Anyway, looks OK for me :)
Have a nice fortnight
Signature · 3 lines
Martin `MJ' Mares <[email protected]> http://atrey.karlin.mff.cuni.cz/~mj/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth Next lecture on time travel will be held on previous Monday.