Skip to contentSkip to conversation

cpumask cleanup patches dont build

PATCH Ashok Raj 2 participants 2 messages May 6, 2004

lore
Share & tools
lore

Ashok Raj

author
#0 lore raw

Hi Paul

Appears that some changes are still missed.

i ran into sched.c the following seems to fix it

---

 linux-2.6.6-rc3-mm2-root/kernel/sched.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
kernel/sched.c 2004-05-06 14:09:40.786504501 -0700 renamed from kernel/sched.c~pj_cpus_complement 2004-05-06 14:03:14.853689716 -0700 +1 -1
diff -puN kernel/sched.c~pj_cpus_complement kernel/sched.c
@@ -3666,7 +3666,7 @@ static void migrate_all_tasks(int src_cp
                        dest_cpu = any_online_cpu(tsk->cpus_allowed);
                if (dest_cpu == NR_CPUS) {
                        cpus_clear(tsk->cpus_allowed);
-                       cpus_complement(tsk->cpus_allowed);
+                       cpus_complement(tsk->cpus_allowed, tsk->cpus_allowed);
                        dest_cpu = any_online_cpu(tsk->cpus_allowed);
  
                        /* Don't tell them about moving exiting tasks
#1 lore raw

Right you are - that cpus_complement was inside an ifdef CONFIG_HOTPLUG_CPU section that was added after I did my global searches for such calls. And obviously, you are the first to build this with HOTPLUG enabled.

Thanks, Ashok.

Signature · 3 lines
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <[email protected]> 1.650.933.1373