Skip to contentSkip to conversation

PCI devices with no PCI_CACHE_LINE_SIZE implemented

PATCH New Matt Domsch 1 participant 1 message May 6, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI devices with no PCI_CACHE_LINE_SIZE implemented

Marcelo, below is a patch to lower the severity of this printk to KERN_DEBUG, as there are devices which (properly) don't implement the PCI_CACHE_LINE_SIZE register, and it's not a bug, so don't print at a WARNING level. GregKH accepted the equivalent patch for 2.6.

Thanks,
Matt

----- Forwarded message from Matt Domsch <[email protected]> -----

Date: Wed, 5 May 2004 17:50:53 -0500
From: Matt Domsch <[email protected]>
To: Greg KH <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: PCI devices with no PCI_CACHE_LINE_SIZE implemented
In-Reply-To: <[email protected]>

Quoted 6 lines · Greg KH
Quoted 2 lines · Matt Domsch

a) need this be a warning, wouldn't KERN_DEBUG suffice, if a message is needed at all? This is printed in pci_generic_prep_mwi().

Yes, we should make that KERN_DEBUG. I don't have a problem with that. Care to make a patch?

Patch for 2.4.27-pre1 appended.

Thanks,
Matt

Signature · 17 lines
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

===== drivers/pci/pci.c 1.47 vs edited =====
--- 1.47/drivers/pci/pci.c	Mon Sep 22 07:27:35 2003
+++ edited/drivers/pci/pci.c	Wed May  5 17:49:13 2004
@@ -943,7 +943,7 @@
 	if (cacheline_size == pci_cache_line_size)
 		return 0;
 
-	printk(KERN_WARNING "PCI: cache line size of %d is not supported "
+	printk(KERN_DEBUG "PCI: cache line size of %d is not supported "
 	       "by device %s\n", pci_cache_line_size << 2, dev->slot_name);
 
 	return -EINVAL;