Skip to contentSkip to conversation

fix MOD_{INC,DEC}_USE_COUNT use in prominfo

PATCH In review Christoph Hellwig 2 participants 2 messages May 7, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix MOD_{INC,DEC}_USE_COUNT use in prominfo

set proper proc_entry owner instead. btw, the file is complete mess and wants a rewrite at least - if not a rearchitecture for a saner interface.

arch/ia64/sn/kernel/sn2/prominfo_proc.c +7 -6
@@ -228,11 +228,9 @@
 {
 	int len = 0;
 
-	MOD_INC_USE_COUNT;
 	/* data holds the pointer to this node's FIT */
 	len = dump_version(page, (unsigned long *)data);
 	len = proc_calc_metrics(page, start, off, count, eof, len);
-	MOD_DEC_USE_COUNT;
 	return len;
 }
 
@@ -242,11 +240,9 @@
 {
 	int len = 0;
 
-	MOD_INC_USE_COUNT;
 	/* data holds the pointer to this node's FIT */
 	len = dump_fit(page, (unsigned long *)data);
 	len = proc_calc_metrics(page, start, off, count, eof, len);
-	MOD_DEC_USE_COUNT;
 
 	return len;
 }
@@ -310,6 +306,7 @@
 prominfo_init(void)
 {
 	struct proc_dir_entry **entp;
+	struct proc_dir_entry *p;
 	cnodeid_t cnodeid;
 	nasid_t nasid;
 	char name[NODE_NAME_LEN];
@@ -333,12 +330,16 @@
 		sprintf(name, "node%d", cnodeid);
 		*entp = proc_mkdir(name, sgi_prominfo_entry);
 		nasid = cnodeid_to_nasid(cnodeid);
-		create_proc_read_entry(
+		p = create_proc_read_entry(
 			"fit", 0, *entp, read_fit_entry,
 			lookup_fit(nasid));
-		create_proc_read_entry(
+		if (p)
+			p->owner = THIS_MODULE;
+		p = create_proc_read_entry(
 			"version", 0, *entp, read_version_entry,
 			lookup_fit(nasid));
+		if (p)
+			p->owner = THIS_MODULE;
 	}
 
 	return 0;
#1 lore raw
Quoted 3 lines · Christoph Hellwig

set proper proc_entry owner instead. btw, the file is complete mess and wants a rewrite at least - if not a rearchitecture for a saner interface.

The fixes look fine. I'm hoping to put this info into sysfs under each node at some point, but I've got to get Greg's ok about the format and how it's presented.

Jesse