Skip to contentSkip to conversation

remove comx drivers from tree

PATCH In review Christoph Hellwig 3 participants 4 messages May 7, 2004 – May 16, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove comx drivers from tree

the drivers have been broken since pre-2.4.0, like referencing a symbol that was made procfs-internal in 2.3.x, haven't received maintainer updates for about the same period and MOD_{INC,DEC}_USE_COUNT usage that pretty much unfixable (inside warts of _horrible_ procfs abuse).

I'd say just kill them.

drivers/net/wan/Kconfig +0 -113
@@ -57,119 +57,6 @@
 	  The driver will be compiled as a module: the
 	  module will be called cosa.
 
-#
-# COMX drivers
-#
-# Not updated to 2.6.
-config COMX
-	tristate "MultiGate (COMX) synchronous serial boards support"
-	depends on WAN && (ISA || PCI) && BROKEN
-	---help---
-	  Drivers for the PC synchronous serial adapters by
-	  ITConsult-Pro Co, Hungary.
-
-	  Read <file:Documentation/networking/comx.txt> for help on configuring
-	  and using COMX interfaces. Further info on these cards can be found
-	  at <http://www.itc.hu/> or <[email protected]>.
-
-	  Say Y if you want to use any board from the MultiGate (COMX)
-	  family, you must also say Y to "/proc file system support"
-	  (CONFIG_PROC_FS) in order to use these drivers.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called comx.
-
-config COMX_HW_COMX
-	tristate "Support for COMX/CMX/HiCOMX boards"
-	depends on COMX
-	help
-	  Driver for the 'CMX', 'COMX' and 'HiCOMX' boards.
-
-	  You will need additional firmware to use these cards, which are
-	  downloadable from <ftp://ftp.itc.hu/>.
-
-	  Say Y if you have a board like this.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called comx-hw-comx.
-
-config COMX_HW_LOCOMX
-	tristate "Support for LoCOMX board"
-	depends on COMX
-	help
-	  Driver for the 'LoCOMX' board.
-
-	  Say Y if you have a board like this.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called comx-hw-locomx.
-
-config COMX_HW_MIXCOM
-	tristate "Support for MixCOM board"
-	depends on COMX
-	---help---
-	  Driver for the 'MixCOM' board.
-
-	  If you want to use the watchdog device on this card, you should
-	  select it in the Watchdog Cards section of the Character Devices
-	  configuration. The ISDN interface of this card is Teles 16.3
-	  compatible, you should enable it in the ISDN configuration menu. The
-	  driver for the flash ROM of this card is available separately on
-	  <ftp://ftp.itc.hu/>.
-
-	  Say Y if you have a board like this.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called comx-hw-mixcom.
-
-config COMX_HW_MUNICH
-	tristate "Support for MUNICH based boards: SliceCOM, PCICOM (WelCOM)"
-	depends on COMX
-	---help---
-	  Driver for the 'SliceCOM' (channelized E1) and 'PciCOM' (X21) boards.
-
-	  Read <file:Documentation/networking/slicecom.txt> for help on
-	  configuring and using SliceCOM interfaces. Further info on these
-	  cards can be found at <http://www.itc.hu> or <[email protected]>.
-
-	  Say Y if you have a board like this.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called comx-hw-munich.
-
-config COMX_PROTO_PPP
-	tristate "Support for HDLC and syncPPP protocols on MultiGate boards"
-	depends on COMX
-	help
-	  Cisco-HDLC and synchronous PPP protocol driver.
-
-	  Say Y if you want to use either protocol.
-
-	  To compile this as a module, choose M here: the
-	  module will be called comx-proto-ppp.
-
-config COMX_PROTO_LAPB
-	tristate "Support for LAPB protocol on MultiGate boards"
-	depends on WAN && (COMX!=n && LAPB=m && LAPB || LAPB=y && COMX)
-	help
-	  LAPB protocol driver.
-
-	  Say Y if you want to use this protocol.
-
-	  To compile this as a module, choose M here: the
-	  module will be called comx-proto-lapb.
-
-config COMX_PROTO_FR
-	tristate "Support for Frame Relay on MultiGate boards"
-	depends on COMX
-	help
-	  Frame Relay protocol driver.
-
-	  Say Y if you want to use this protocol.
-
-	  To compile this as a module, choose M here: the
-	  module will be called comx-proto-fr.
-
 config DSCC4
 	tristate "Etinc PCISYNC serial board support"
 	depends on WAN && PCI && m

===== drivers/net/wan/Makefile 1.18 vs edited =====

drivers/net/wan/Makefile +0 -8
@@ -32,14 +32,6 @@
 
 obj-$(CONFIG_HOSTESS_SV11)	+= z85230.o	syncppp.o	hostess_sv11.o
 obj-$(CONFIG_SEALEVEL_4021)	+= z85230.o	syncppp.o	sealevel.o
-obj-$(CONFIG_COMX)		+= 				comx.o
-obj-$(CONFIG_COMX_HW_COMX)	+= 				comx-hw-comx.o
-obj-$(CONFIG_COMX_HW_LOCOMX)	+= z85230.o	syncppp.o	comx-hw-locomx.o
-obj-$(CONFIG_COMX_HW_MIXCOM)	+=				comx-hw-mixcom.o
-obj-$(CONFIG_COMX_HW_MUNICH)	+=				comx-hw-munich.o
-obj-$(CONFIG_COMX_PROTO_PPP)	+=		syncppp.o	comx-proto-ppp.o
-obj-$(CONFIG_COMX_PROTO_LAPB)	+=				comx-proto-lapb.o
-obj-$(CONFIG_COMX_PROTO_FR)	+=				comx-proto-fr.o
 obj-$(CONFIG_COSA)		+=		syncppp.o	cosa.o
 obj-$(CONFIG_FARSYNC)		+=		syncppp.o	farsync.o
 obj-$(CONFIG_DSCC4)             +=				dscc4.o

===== drivers/net/wan/comx-hw-comx.c 1.13 vs edited =====

drivers/net/wan/comx-hw-comx.c +0 -1449

1,450 lines not on this page · raw message

===== drivers/net/wan/comx-hw-locomx.c 1.10 vs edited =====

drivers/net/wan/comx-hw-locomx.c +0 -495

496 lines not on this page · raw message

===== drivers/net/wan/comx-hw-mixcom.c 1.12 vs edited =====

drivers/net/wan/comx-hw-mixcom.c +0 -959

921 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

===== drivers/net/wan/comx-hw-munich.c 1.17 vs edited =====

drivers/net/wan/comx-hw-munich.c +0 -2853

2,853 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

===== drivers/net/wan/comx-proto-fr.c 1.13 vs edited =====

drivers/net/wan/comx-proto-fr.c +0 -1013

1,013 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

===== drivers/net/wan/comx-proto-lapb.c 1.12 vs edited =====

drivers/net/wan/comx-proto-lapb.c +0 -550

550 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

===== drivers/net/wan/comx-proto-ppp.c 1.6 vs edited =====

drivers/net/wan/comx-proto-ppp.c +0 -268

268 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

===== drivers/net/wan/comx.c 1.23 vs edited =====

drivers/net/wan/comx.c +0 -1127

1,127 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

===== drivers/net/wan/comx.h 1.2 vs edited =====

drivers/net/wan/comx.h +0 -231

231 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

===== drivers/net/wan/comxhw.h 1.1 vs edited =====

drivers/net/wan/comxhw.h +0 -112

112 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 6 lines · Christoph Hellwig

the drivers have been broken since pre-2.4.0, like referencing a symbol that was made procfs-internal in 2.3.x, haven't received maintainer updates for about the same period and MOD_{INC,DEC}_USE_COUNT usage that pretty much unfixable (inside warts of _horrible_ procfs abuse).

I'd say just kill them.

I have applied this to my netdev-2.6 tree, and so it should show up in -mm sometime.

 drivers/net/wan/Kconfig           |  113 -
 drivers/net/wan/Makefile          |    8
 drivers/net/wan/comx-hw-comx.c    | 1449 -------------------
 drivers/net/wan/comx-hw-locomx.c  |  495 ------
 drivers/net/wan/comx-hw-mixcom.c  |  959 ------------
 drivers/net/wan/comx-hw-munich.c  | 2853 
--------------------------------------
 drivers/net/wan/comx-proto-fr.c   | 1013 -------------
 drivers/net/wan/comx-proto-lapb.c |  550 -------
 drivers/net/wan/comx-proto-ppp.c  |  268 ---
 drivers/net/wan/comx.c            | 1127 ---------------
 drivers/net/wan/comx.h            |  231 ---
 drivers/net/wan/comxhw.h          |  112 -
 12 files changed, 9178 deletions(-)

Even though it is quite moldy, I want to give people some time to object before I remove it upstream.

BTW, I plan to remove rcpci driver at the suggestion of Pete Popov, as well. It seems it's another "hasn't really worked since late 2.3.x days" driver, and nobody really has the hardware from this defunct company anymore, apparently.

Jeff

#2 lore raw
Quoted 16 lines · Jeff Garzik

I have applied this to my netdev-2.6 tree, and so it should show up in -mm sometime.

  drivers/net/wan/Kconfig           |  113 -
  drivers/net/wan/Makefile          |    8
  drivers/net/wan/comx-hw-comx.c    | 1449 -------------------
  drivers/net/wan/comx-hw-locomx.c  |  495 ------
  drivers/net/wan/comx-hw-mixcom.c  |  959 ------------
  drivers/net/wan/comx-hw-munich.c  | 2853
  --------------------------------------
  drivers/net/wan/comx-proto-fr.c   | 1013 -------------
  drivers/net/wan/comx-proto-lapb.c |  550 -------
  drivers/net/wan/comx-proto-ppp.c  |  268 ---
  drivers/net/wan/comx.c            | 1127 ---------------
  drivers/net/wan/comx.h            |  231 ---
  drivers/net/wan/comxhw.h          |  112 -

While obviously I don't object (we should list removed things along with kernel version somewhere, though)... I could possibly port the drivers to my generic HDLC code, if someone sends me the hardware in question. Sure, I will never send it back, and it has to have V.35 or V.24 interface, so I can connect it to something.

Signature · 1 line
Krzysztof Halasa, B*FH
#3 lore raw
Quoted 5 lines · Krzysztof Halasa

While obviously I don't object (we should list removed things along with kernel version somewhere, though)... I could possibly port the drivers to my generic HDLC code, if someone sends me the hardware in question. Sure, I will never send it back, and it has to have V.35 or V.24 interface, so I can connect it to something.

Then, *bang*, it's gone :)

We can resurrect if someone appears with hardware, and cares enough to bring the driver back to life... Older kernels are archived on the Internet forever, after all :)

Jeff