Skip to contentSkip to conversation

atyfb (2.6): Memory type correction

PATCH In review Ville Syrjälä 2 participants 3 messages May 7, 2004 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 atyfb (2.6): Memory type correction

This patch changes the memory type message to match reality. This agrees with both my hardware and the Mobility register specs.

Signature · 3 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/
drivers/video/aty/atyfb_base.c renamed from drivers/video/aty/atyfb_base.c.orig +4 -4
@@ -457,9 +457,9 @@
 #endif /* CONFIG_FB_ATY_GX */
 #ifdef CONFIG_FB_ATY_CT
 static char ram_edo[] __initdata = "EDO";
-static char ram_sdram[] __initdata = "SDRAM";
-static char ram_sgram[] __initdata = "SGRAM";
-static char ram_wram[] __initdata = "WRAM";
+static char ram_sdram[] __initdata = "SDRAM (1:1)";
+static char ram_sgram[] __initdata = "SGRAM (1:1)";
+static char ram_sdram32[] __initdata = "SDRAM (2:1) (32-bit)";
 static char ram_off[] __initdata = "OFF";
 #endif /* CONFIG_FB_ATY_CT */
 
@@ -476,7 +476,7 @@
 #ifdef CONFIG_FB_ATY_CT
 static char *aty_ct_ram[8] __initdata = {
 	ram_off, ram_dram, ram_edo, ram_edo,
-	ram_sdram, ram_sgram, ram_wram, ram_resv
+	ram_sdram, ram_sgram, ram_sdram32, ram_resv
 };
 #endif /* CONFIG_FB_ATY_CT */
 
#1 lore raw
Quoted 2 lines · On Fri, 7 May 2004, Ville [iso-8859-1] Syrjälä wrote:

This patch changes the memory type message to match reality. This agrees with both my hardware and the Mobility register specs.

I took the values from the RAGE II+ manual. So ATI recycled the WRAM value for Mobility? Unless they never actually made boards with WRAM.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3

#2 lore raw
Quoted 6 lines · Geert Uytterhoeven
Quoted 2 lines · On Fri, 7 May 2004, Ville [iso-8859-1] Syrjälä wrote:

This patch changes the memory type message to match reality. This agrees with both my hardware and the Mobility register specs.

I took the values from the RAGE II+ manual. So ATI recycled the WRAM value for Mobility? Unless they never actually made boards with WRAM.

My Rage Pro manual lists WRAM in CONFIG_STAT2.CFG_MEM_TYPEb. And that's the only place where WRAM in mentioned as a valid memory type in my manuals. Also the values of CFG_MEM_TYPEb look like the xor of CONFIG_STAT0.CFG_MEM_TYPE except that WRAM is CFG_MEM_TYPEb=001 and CFG_MEM_TYPE=110 is listed as a reserved value.

Signature · 10 lines
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to
deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3