export clear_pages on ppc32

PATCH In review Olaf Hering 3 participants 6 messages May 10, 2004 – May 11, 2004

lore

Share & tools

lore

Olaf Hering

author

2004-05-10 15:36 UTC #0 lore raw

PATCH 1/1 export clear_pages on ppc32

ext3 as module is not possible in 2.6.6, clear_pages, called from clear_page, is not exported.

arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 renamed from arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200 +1 -0

@@ -73,6 +73,7 @@ int abs(int);
 extern unsigned long mm_ptov (unsigned long paddr);
 
 EXPORT_SYMBOL(clear_page);
+EXPORT_SYMBOL(clear_pages);
 EXPORT_SYMBOL(clear_user_page);
 EXPORT_SYMBOL(do_signal);
 EXPORT_SYMBOL(do_syscall_trace);

--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Tom Rini

2004-05-10 18:42 UTC #1 lore raw

Quoted 8 lines · Olaf Hering

ext3 as module is not possible in 2.6.6, clear_pages, called from clear_page, is not exported.

arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 int abs(int); · line 79

Quoted 7 lines

arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 renamed from arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200 +1 -0
@@ -73,6 +73,7 @@ int abs(int);
 extern unsigned long mm_ptov (unsigned long paddr);
 
 EXPORT_SYMBOL(clear_page);
+EXPORT_SYMBOL(clear_pages);
 EXPORT_SYMBOL(clear_user_page);
 EXPORT_SYMBOL(do_signal);
 EXPORT_SYMBOL(do_syscall_trace);

Where are clean_page and clear_pages defined? They should both be exported there.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Olaf Hering

author

2004-05-10 19:17 UTC #2 lore raw

Quoted 12 lines · Tom Rini

Quoted 10 lines · Olaf Hering
ext3 as module is not possible in 2.6.6, clear_pages, called from clear_page, is not exported.
arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 renamed from arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200 +0 -0
@@ -73,6 +73,7 @@ int abs(int);
 extern unsigned long mm_ptov (unsigned long paddr);
 

Quoted 8 lines

arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 int abs(int); · line 79
Quoted 5 lines
arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 renamed from arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200 +1 -0
 EXPORT_SYMBOL(clear_page);
+EXPORT_SYMBOL(clear_pages);
 EXPORT_SYMBOL(clear_user_page);
 EXPORT_SYMBOL(do_signal);
 EXPORT_SYMBOL(do_syscall_trace);
Where are clean_page and clear_pages defined? They should both be exported there.

in misc.S, or some other .S file.

--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Tom Rini

2004-05-10 19:57 UTC #3 lore raw

Quoted 20 lines · Olaf Hering

Quoted 10 lines · Tom Rini
Quoted 9 lines · Olaf Hering
ext3 as module is not possible in 2.6.6, clear_pages, called from clear_page, is not exported.
arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 renamed from arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200 +0 -0
@@ -73,6 +73,7 @@ int abs(int);
 extern unsigned long mm_ptov (unsigned long paddr);
 
Quoted 8 lines
arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 int abs(int); · line 79
Quoted 5 lines
arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200 renamed from arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200 +1 -0
 EXPORT_SYMBOL(clear_page);
+EXPORT_SYMBOL(clear_pages);
 EXPORT_SYMBOL(clear_user_page);
 EXPORT_SYMBOL(do_signal);
 EXPORT_SYMBOL(do_syscall_trace);
Where are clean_page and clear_pages defined? They should both be exported there.

Quoted 1 line

in misc.S, or some other .S file.

OK, nevermind then.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Paul Mackerras

2004-05-10 22:42 UTC #4 lore raw

In reply to Olaf Hering

Quoted 2 lines · Olaf Hering

ext3 as module is not possible in 2.6.6, clear_pages, called from clear_page, is not exported.

clear_page is an inline function now, we should remove its export.

Paul.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Olaf Hering

author

2004-05-11 13:25 UTC #5 lore raw

Quoted 7 lines · Paul Mackerras

Quoted 2 lines · Olaf Hering
ext3 as module is not possible in 2.6.6, clear_pages, called from clear_page, is not exported.
clear_page is an inline function now, we should remove its export.

Good point:

arch/ppc/kernel/ppc_ksyms.c 2004-05-11 15:24:57.000000000 +0200 renamed from arch/ppc/kernel/ppc_ksyms.c 2004-05-10 04:33:19.000000000 +0200 +1 -1

diff -p -purN linux-2.6.6/arch/ppc/kernel/ppc_ksyms.c linux-2.6.6.ppc32/arch/ppc/kernel/ppc_ksyms.c
@@ -72,7 +72,7 @@ int abs(int);
 
 extern unsigned long mm_ptov (unsigned long paddr);
 
-EXPORT_SYMBOL(clear_page);
+EXPORT_SYMBOL(clear_pages);
 EXPORT_SYMBOL(clear_user_page);
 EXPORT_SYMBOL(do_signal);
 EXPORT_SYMBOL(do_syscall_trace);

--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/