Skip to contentSkip to conversation

linux-2.6.6: ide-disks are shutdown on reboot

DISCUSSION Gerardo Exequiel Pozzi 3 participants 4 messages May 11, 2004

lore
Share & tools
lore
#0 lore raw

Hi people,

With the recent version 2.6.6 my ide disks are shutdown on reboot, this not happens with 2.6.5. I try booting with acpi=off and it behaves equal, disk shutdown on reboot.
This like is waited for from now on? :(

The disks only will be shutdown on halt no in reboot :)

I suspect that the problem are in changeset 1.1587.31.6

Please CC to me, i am not subscribed to lkml.

Take care,
djgera

#1 lore raw
Quoted 2 lines · Gerardo Exequiel Pozzi

With the recent version 2.6.6 my ide disks are shutdown on reboot, this not happens with 2.6.5. I try booting with acpi=off and it behaves equal, disk shutdown on reboot.

Wildly annoying isn't it? Seems to be a generic problem with linux not differentiatinng between REBOOT and HALT/POWEROFF. Andrew Morton just posted a patch to deplex them:

http://marc.theaimsgroup.com/?l=linux-kernel&m=108425291909843&w=2

You can wait for the IDE crowd to use that to implement a proper fix or staple the attached hack on top if it must go now.

Rene.

drivers/ide/ide-disk.c +5 -4
@@ -1704,10 +1704,11 @@
 
 static void ide_device_shutdown(struct device *dev)
 {
-	ide_drive_t *drive = container_of(dev, ide_drive_t, gendev);
-
-	printk("Shutdown: %s\n", drive->name);
-	dev->bus->suspend(dev, PM_SUSPEND_STANDBY);
+	if (system_state != SYSTEM_RESTART) {
+		ide_drive_t *drive = container_of(dev, ide_drive_t, gendev);
+		printk("Shutdown: %s\n", drive->name);
+		dev->bus->suspend(dev, PM_SUSPEND_STANDBY);
+	}
 }
 
 /*
#2 lore raw

drivers/ide/ide-disk.c line 1707

Quoted 1 line · Rene Herman
drivers/ide/ide-disk.c +1 -0
+	if (system_state != SYSTEM_RESTART) {

drivers/ide/ide-disk.c:1707: error: `SYSTEM_RESTART' undeclared (first use in this function)

I cannot find definition of SYSTEM_RESTART with grep too.

Signature · 1 line
I am a viral sig. Please copy me and help me spread. Thank you.