Skip to contentSkip to conversation

Powernow-k8 buggy BIOS override for 2.6.6]

PATCH Dave Jones 2 participants 2 messages May 13, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw
Quoted 10 lines · Tony Lindgren

Following is the updated patch to make the powernow-k8 driver work on machines with buggy BIOS, such as emachines m6805.

The patch overrides the PST table only if check_pst_table() fails.

The minimum value for the override is 800MHz, which is the lowest value on all x86_64 systems AFAIK. The max value is the current running value.

This patch should be safe to apply, even if Pavel's ACPI table check is added to the driver. Or does anybody see a problem with it?

Does the ACPI fallback not do the right thing ?
I don't really see the point of limping along with a 2-state PST if we can derive the proper info from the ACPI table.

Dave

#2 lore raw
Quoted 7 lines · Dave Jones
Quoted 5 lines · Tony Lindgren

Following is the updated patch to make the powernow-k8 driver work on machines with buggy BIOS, such as emachines m6805.

The patch overrides the PST table only if check_pst_table() fails.

Quoted 7 lines
Quoted 5 lines

The minimum value for the override is 800MHz, which is the lowest value on all x86_64 systems AFAIK. The max value is the current running value.

This patch should be safe to apply, even if Pavel's ACPI table check is added to the driver. Or does anybody see a problem with it?

Does the ACPI fallback not do the right thing ?

Does not work for me. But looks like that's because I had to turn off ACPI processor module since 2.6.6 since it would hang my system. It could also be that the hang is caused by the powernow-k8. I will check that.

Quoted 2 lines

I don't really see the point of limping along with a 2-state PST if we can derive the proper info from the ACPI table.

Sure if the ACPI table check works properly. But even with 2-state PST, being able to change from 1800MHz to 800MHz on battery increases the battery life quite a bit. And it does not necessarily require ACPI :)

Regards,

Tony