configh
PATCH 1/1 configh
ChangeLog:
* Patch by Robert Schwebel, 14 May 2004:
use config.h (which is needed in serial.c for CFG_HZ)
Robert
Signature · 27 lines
Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
Handelsregister: Amtsgericht Hildesheim, HRA 2686
Hornemannstra?e 12, 31137 Hildesheim, Germany
Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4
-------------- next part --------------
#
# Author: Robert Schwebel <[email protected]>
#
# Description: ChangeLog:
# * Patch by Robert Schwebel, 14 May 2004:
# use config.h (which is needed in serial.c for CFG_HZ)
#
# State: 2004-05-15: submitted
#
diff -urN -x CVS -x .patches u-boot/cpu/arm720t/serial.c u-boot-innokom-orig/cpu/arm720t/serial.c
--- u-boot/cpu/arm720t/serial.c 2004-03-11 13:17:44.000000000 +0100
+++ u-boot-innokom-orig/cpu/arm720t/serial.c 2004-03-12 07:30:06.000000000 +0100
@@ -29,6 +29,7 @@
*/
#include <common.h>
+#include <config.h>
#include <clps7111.h>
#ifndef CONFIG_NETARMPATCH 1/1 configh
Quoted 3 lines · In message <[email protected]> you wrote:
* Patch by Robert Schwebel, 14 May 2004:
useconfig.h(which is needed inserial.cforCFG_HZ)
What makes you think this is needed? The code compiles fine as is...
Quoted 3 lines
#include <
common.h>
+#include <config.h>
#include <clps7111.h>
And actually this _IS_ redundand, since "include/common.h" already includes <config.h>.
Which problem are you tring to fix? I can't see any...
Rejected.
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de If it went on at this rate, in several billion years he'd be rich beyond his wildest dreams! - Terry Pratchett, _Soul Music_
PATCH 1/1 configh
Quoted 11 lines · Wolfgang Denk
Quoted 2 lines
* Patch by Robert Schwebel, 14 May 2004:
useconfig.h(which is needed inserial.cforCFG_HZ)What makes you think this is needed? The code compiles fine as is...
Quoted 3 lines
#include <
common.h>
+#include <config.h>
#include <clps7111.h>And actually this _IS_ redundand, since "
include/common.h" already includes <config.h>.
It's normally good coding practise to include the files which have the stuff you actually need, instead of relying on other include files including other includefiles and wondering why things break if somebody changes something in the other file. But the decision is surely up to you.
Robert
Signature · 5 lines
Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
Handelsregister: Amtsgericht Hildesheim, HRA 2686
Hornemannstra?e 12, 31137 Hildesheim, Germany
Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4PATCH 1/1 configh
Quoted 4 lines · In message <[email protected]> you wrote:
It's normally good coding practise to include the files which have the stuff you actually need, instead of relying on other include files including other includefiles and wondering why things break if somebody
Actually config.h is needed more or less everywhere so I think it makes more sense to have it included once (in common.h) instead of adding it in more than 500 other files.
Quoted 2 lines
changes something in the other file. But the decision is surely up to you.
Nothing is broken, so I see no need to fix anything.
Best regards,
Wolfgang Denk
Signature · 3 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de EMACS belongs in <sys/errno.h>: Editor too big!